From: Chris Brandt <Chris.Brandt@renesas.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Simon Horman <horms+renesas@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: RE: [PATCH] i2c: riic: remove clock and frequency restrictions
Date: Wed, 18 Oct 2017 16:41:57 +0000 [thread overview]
Message-ID: <SG2PR06MB1165C76C6B35511B21CC70668A4D0@SG2PR06MB1165.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20171018163725.ik6ieofpd6ehilbo@ninjato>
On Wednesday, October 18, 2017 1, Wolfram Sang wrote:
> > + brl -= t->scl_fall_ns / (1000000000/rate);
> > + brh -= t->scl_rise_ns / (1000000000/rate);
>
> However you solve the precision issue, please take care about the "space
> around operators" rule afterwards. checkpatch should help you there.
OK.
I ran checkpatch and fixed everything it found, but it didn't flag that one.
$ scripts/checkpatch.pl z_patches/riic/S4V1/*
total: 0 errors, 0 warnings, 169 lines checked
z_patches/riic/S4V1/0001-i2c-riic-remove-clock-and-frequency-restrictions.patch has no obvious style problems and is ready for submission.
Chris
next prev parent reply other threads:[~2017-10-18 16:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 14:04 [PATCH] i2c: riic: remove clock and frequency restrictions Chris Brandt
2017-10-18 14:25 ` Geert Uytterhoeven
2017-10-18 14:25 ` Geert Uytterhoeven
2017-10-18 15:10 ` Chris Brandt
2017-10-18 15:14 ` Geert Uytterhoeven
2017-10-18 15:47 ` Chris Brandt
2017-10-18 16:37 ` Wolfram Sang
2017-10-18 16:41 ` Chris Brandt [this message]
2017-10-18 16:44 ` Wolfram Sang
2017-10-26 20:36 ` Wolfram Sang
2017-10-27 15:37 ` Chris Brandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SG2PR06MB1165C76C6B35511B21CC70668A4D0@SG2PR06MB1165.apcprd06.prod.outlook.com \
--to=chris.brandt@renesas.com \
--cc=geert@linux-m68k.org \
--cc=horms+renesas@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.