From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: Josef Bacik <josef@toxicpanda.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"kernel-team@fb.com" <kernel-team@fb.com>
Subject: Re: [PATCH 1/5] btrfs: unify the ro checking for mount options
Date: Tue, 29 Sep 2020 06:36:08 +0000 [thread overview]
Message-ID: <SN4PR0401MB3598DAB60C2357B1023A0E0C9B320@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: be964e53-0adb-a829-8057-fe5c9115fe70@toxicpanda.com
On 28/09/2020 20:23, Josef Bacik wrote:
> To avoid the multiple calls if we're not read only, otherwise it'll be multiple
> function calls to check that that SB_RDONLY is set. The compiler will probably
> optimize that away, but I just went with this instead. I'm good either way if
> people have strong opinions one way or the other.
The name check_ro_option() really suggests it checking for a read-only option and
having multiple calls if RO isn't set really won't be a problem IMHO as we're not
really in the fast-path here, but I don't have a strong opinion on it either.
next prev parent reply other threads:[~2020-09-29 6:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 15:32 [PATCH 0/5] New rescue mount options Josef Bacik
2020-09-24 15:32 ` [PATCH 1/5] btrfs: unify the ro checking for " Josef Bacik
2020-09-25 0:36 ` Qu Wenruo
2020-09-28 12:37 ` Johannes Thumshirn
2020-09-28 18:23 ` Josef Bacik
2020-09-29 6:36 ` Johannes Thumshirn [this message]
2020-09-24 15:32 ` [PATCH 2/5] btrfs: push the NODATASUM check into btrfs_lookup_bio_sums Josef Bacik
2020-09-25 0:39 ` Qu Wenruo
2020-09-28 18:28 ` Josef Bacik
2020-09-28 12:39 ` Johannes Thumshirn
2020-09-24 15:32 ` [PATCH 3/5] btrfs: introduce rescue=ignorebadroots Josef Bacik
2020-09-25 0:47 ` Qu Wenruo
2020-09-28 18:24 ` Josef Bacik
2020-09-24 15:32 ` [PATCH 4/5] btrfs: introduce rescue=ignoredatacsums Josef Bacik
2020-09-25 0:50 ` Qu Wenruo
2020-09-24 15:32 ` [PATCH 5/5] btrfs: introduce rescue=all Josef Bacik
2020-09-25 0:51 ` Qu Wenruo
2020-09-25 0:34 ` [PATCH 0/5] New rescue mount options Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB3598DAB60C2357B1023A0E0C9B320@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.