From: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
To: "dsterba@suse.cz" <dsterba@suse.cz>
Cc: David Sterba <dsterba@suse.com>,
Nikolay Borisov <nborisov@suse.com>,
"linux-btrfs @ vger . kernel . org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 6/6] btrfs: remove buffer_heads form superblock mirror integrity checking
Date: Fri, 24 Jan 2020 14:59:06 +0000 [thread overview]
Message-ID: <SN4PR0401MB3598FE1DF8863E611D4C183F9B0E0@SN4PR0401MB3598.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200124142211.GL3929@twin.jikos.cz
On 24/01/2020 15:22, David Sterba wrote:
[...]
>>
>> - brelse(bh);
>> + btrfs_release_disk_super(page);
>
> This could be the cleaned up to merge all error exits to jump to this
> common block. Integrity checker is an old code so nobody cared enough to
> clean it up, but it would be good to do it now when there are pople
> looking at the code.
>
> As mentioned before, btrfs_release_disk_super should be opencoded so
> this would make it more straightfowrard to have only one place instad of
> each error exit brelse replaced by put_page/kunmap.
Sure no problem. I already have a internal branch with
put_page()/kunmap(), but before sending it out I want to address
Nikolay's comments regarding the page locking and this still causes
deadlocks here.
Thanks,
Johannes
prev parent reply other threads:[~2020-01-24 14:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 8:18 [PATCH v2 0/6] btrfs: remove buffer heads form superblock handling Johannes Thumshirn
2020-01-23 8:18 ` [PATCH v2 1/6] btrfs: export btrfs_release_disk_super Johannes Thumshirn
2020-01-23 13:42 ` Josef Bacik
2020-01-23 8:18 ` [PATCH v2 2/6] btrfs: remove buffer heads from super block reading Johannes Thumshirn
2020-01-23 13:51 ` Josef Bacik
2020-01-23 13:53 ` Johannes Thumshirn
2020-01-23 14:13 ` Nikolay Borisov
2020-01-23 16:45 ` Johannes Thumshirn
2020-01-23 22:25 ` David Sterba
2020-01-24 13:54 ` David Sterba
2020-01-24 14:03 ` David Sterba
2020-01-23 8:18 ` [PATCH v2 3/6] btrfs: remove use of buffer_heads from superblock writeout Johannes Thumshirn
2020-01-23 13:59 ` Josef Bacik
2020-01-23 14:19 ` Nikolay Borisov
2020-01-24 14:15 ` David Sterba
2020-01-23 8:18 ` [PATCH v2 4/6] btrfs: remove btrfsic_submit_bh() Johannes Thumshirn
2020-01-23 14:00 ` Josef Bacik
2020-01-23 8:18 ` [PATCH v2 5/6] btrfs: remove buffer_heads from btrfsic_process_written_block() Johannes Thumshirn
2020-01-23 14:00 ` Josef Bacik
2020-01-23 8:18 ` [PATCH v2 6/6] btrfs: remove buffer_heads form superblock mirror integrity checking Johannes Thumshirn
2020-01-23 14:03 ` Josef Bacik
2020-01-23 14:23 ` Nikolay Borisov
2020-01-24 14:22 ` David Sterba
2020-01-24 14:59 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN4PR0401MB3598FE1DF8863E611D4C183F9B0E0@SN4PR0401MB3598.namprd04.prod.outlook.com \
--to=johannes.thumshirn@wdc.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.