All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhou qi <atmgnd@outlook.com>
To: "Volker Rümelin" <vr_qemu@t-online.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: 回复: [PATCH] Fix video playback slowdown when spice client no audio enabled
Date: Sat, 19 Sep 2020 09:41:25 +0000	[thread overview]
Message-ID: <SYBP282MB00120DBA84D39F5FF8F32514C93C0@SYBP282MB0012.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <e3006ac7-b92b-40b0-e3b8-15b81a26647c@t-online.de>

Sorry for the late reply, I am not working on improve this patch(at least not now), And you are welcome to send your patches.


发件人: Volker Rümelin <vr_qemu@t-online.de>
发送时间: 2020年9月18日 1:22
收件人: zhou qi <atmgnd@outlook.com>
抄送: qemu-devel@nongnu.org <qemu-devel@nongnu.org>
主题: Re: [PATCH] Fix video playback slowdown when spice client no audio enabled 
 

> Hello Qi,
>
> your patch breaks audio playback with the dsoundaudio backend.
>
> I suggest you make the following changes:
>
> - Test for size == 0 first and leave the loop in that case.
> - For buf == NULL drop size bytes. Don't leave the loop with break or return.
> - Verify all audio backends adhere to the new rules and fix them if necessary. It's quite possible no patches are needed.
> - Rate limit the audio stream in function line_out_get_buffer() in audio/spiceaudio.c for the noaudio case too. Have a look at audio/spiceaudio.c at version v4.1.0. The code there was correct.
>
> Please don't forget to run scripts/checkpatch.pl on your next patches and don't forget to CC the maintainer.
>
> With best regards,
>
> Volker

Hello Qi,

I wonder if you are already working on an improved fix. Otherwise I will send my patches this weekend to the mailing list.

With best regards,
Volker

      reply	other threads:[~2020-09-19 12:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 11:17 [PATCH] Fix video playback slowdown when spice client no audio enabled zhou qi
2020-09-11 11:53 ` 转发: [PATCH RESEND] " zhou qi
2020-09-13 12:27 ` [PATCH] " Volker Rümelin
2020-09-17 17:22   ` Volker Rümelin
2020-09-19  9:41     ` zhou qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SYBP282MB00120DBA84D39F5FF8F32514C93C0@SYBP282MB0012.AUSP282.PROD.OUTLOOK.COM \
    --to=atmgnd@outlook.com \
    --cc=qemu-devel@nongnu.org \
    --cc=vr_qemu@t-online.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.