RE: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: use more generic whitelisting

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Wolfram Sang <wsa@the-dreams.de>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Cc: "linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: RE: [RFC PATCH] mmc: renesas_sdhi_internal_dmac: use more generic whitelisting
Date: Fri, 6 Apr 2018 14:07:53 +0000	[thread overview]
Message-ID: <TY1PR06MB0992B109555E82B9B7F47DA5D8BA0@TY1PR06MB0992.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20180405164216.7175-1-wsa@the-dreams.de>

Hi Wolfram-san,

Thank you for the patch!

> From: Wolfram Sang, Sent: Friday, April 6, 2018 1:42 AM
> 
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Whitelisting every ES version does not scale. So, we whitelist whole
> SoCs independent of ES version. If we need specific handling for an ES
> version, we put it to the front, so it will be matched first.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> 
> Shimoda-san: here is my example how to re-arrange the whitelisting if we assume
> that the DMA RX fix is going to work out (so this patch depends on it). I
> tested this patch on H3 ES1.0 and ES2.0 with some additional debug output to
> prove that the correct table entry was matched.
> 
> What do you think?

It looks like nice to me! So, I checked this patch and looks good.

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

And, our test team tested this patch and works correctly. So,

Tested-by: Nguyen Viet Dung <dung.nguyen.aj@renesas.com>

Best regards,
Yoshihiro Shimoda