From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Simon Horman <horms@verge.net.au>
Cc: "magnus.damm@gmail.com" <magnus.damm@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v2] arm64: dts: renesas: add/enable USB2.0 peripheral for R-Car [DE]3
Date: Wed, 24 Oct 2018 08:45:46 +0000 [thread overview]
Message-ID: <TY2PR01MB2297BF50E7789F54C1FDAE05D8F60@TY2PR01MB2297.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <OSBPR01MB2293AE3D7213D255E2416B28D8F60@OSBPR01MB2293.jpnprd01.prod.outlook.com>
Hi Simon-san again,
> From: Yoshihiro Shimoda, Sent: Wednesday, October 24, 2018 10:05 AM
>
> Hi Simon-san,
>
> > From: Simon Horman, Sent: Wednesday, October 17, 2018 5:54 PM
> >
> > On Tue, Oct 16, 2018 at 03:05:09PM +0900, Yoshihiro Shimoda wrote:
> > > This patch adds/enables USB2.0 peripheral for R-Car [DE]3 boards.
> > > So, the default mode on each board is:
> > > - R-Car D3 Draak board (has a type-A connector) = host.
> > > - R-Car E3 Ebisu board (has a type-B micro connector) = peripheral.
> > >
> > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >
> > Thanks Shimoda-san,
> >
> > This looks fine to me but I will wait to see if there are other reviews
> > before applying.
> >
> > Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> Thank you for your review!
> However, I'm afraid but, would you wait to apply this patch for a moment?
> I realized this board also connects the ID pin to the SoC. So. I'd like to try to use
> the pin like other R-Car Gen3 boards.
The R-Car E3 Ebisu board can use the ID pin.
# Main problem is my using usb connector converter for R-Car E3 doesn't connect the ID pin to the GND.
# If I used other usb connector converter, it worked correctly...
So, I submitted v3 patch like below:
https://patchwork.kernel.org/patch/10654395/
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2018-10-24 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 6:05 [PATCH v2] arm64: dts: renesas: add/enable USB2.0 peripheral for R-Car [DE]3 Yoshihiro Shimoda
2018-10-17 8:53 ` Simon Horman
2018-10-24 1:05 ` Yoshihiro Shimoda
2018-10-24 8:45 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY2PR01MB2297BF50E7789F54C1FDAE05D8F60@TY2PR01MB2297.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.