RE: [PATCH] arm64: dts: renesas: add sdhi/mmc aliases

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: RE: [PATCH] arm64: dts: renesas: add sdhi/mmc aliases
Date: Mon, 9 Nov 2020 10:35:02 +0000	[thread overview]
Message-ID: <TY2PR01MB3692B844650D190200C3761BD8EA0@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdUxcuafZ_AV__DG1vWoh1dqv_7z7-f85-t5GpzuuKs4eA@mail.gmail.com>

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Monday, November 9, 2020 6:58 PM
> 
> Hi Shimoda-san,
> 
> CC devicetree
> 
> On Fri, Nov 6, 2020 at 10:28 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > After the commit 7320915c8861 ("mmc: Set PROBE_PREFER_ASYNCHRONOUS
> > for drivers that existed in v4.14"), the order of /dev/mmcblkN
> > was not fixed, so that we are hard to use the device as rootfs
> > by using a kernel parameter like root=/dev/mmcblkN. So, add
> > sdhi/mmc aliases.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Thanks for your patch!
> 
> > ---
> >  I'm afraid, but I only tested on r8a77951-salvator-xs.
> >
> >  If possible, I would like to apply this patch into v5.10-stable
> >  because we are hard to use the device as rootfs as I described
> >  the commit description.
> 
> Please don't add aliases for various devices.
> You can specify the root file system to mount using PARTUUID= or
> PARTLABEL= (by the kernel), or using UUID= or LABEL= (by an initramfs).
> This is the same for /dev/sd*, which may change after a kernel
> upgrade.

Thank you for the reply! I understood we should not add aliases for
various devices and we can specify the root file system by using other ways.

Best regards,
Yoshihiro Shimoda