From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] mmc: host: renesas_internal_dmac: add pre_req and post_req support
Date: Wed, 16 Dec 2020 08:00:39 +0000 [thread overview]
Message-ID: <TY2PR01MB3692DA2619361C6A23838259D8C50@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <TY2PR01MB369240E88E0629EDC140D0A1D8C60@TY2PR01MB3692.jpnprd01.prod.outlook.com>
Hi Wolfram-san,
> From: Yoshihiro Shimoda, Sent: Tuesday, December 15, 2020 2:03 PM
<snip>
> I'm sorry again and again. But, I realized the current patch breaks
> "force_pio" mode because tmio_mmc_pio_irq() doesn't take care of {pre,post}_req.
> So, I'll try to refactor tmio core to support {pre,post}_req().
I'm sorry. My fault injection code is bad. In other words, we don't need
to refactor tmio core.
I had added "goto force_pio;" in renesas_sdhi_internal_dmac_start_dma() yesterday.
However, I should have added "goto force_pio_with_unmap;" instead.
Otherwise, the driver unmaps the buffer after pio finished so that reading data
by pio was invalidated by dma_unmap_sg().
So, I'll submit v2 patch later.
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2020-12-16 8:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 13:17 [PATCH] mmc: host: renesas_internal_dmac: add pre_req and post_req support Yoshihiro Shimoda
2020-12-14 15:50 ` Wolfram Sang
2020-12-15 1:32 ` Yoshihiro Shimoda
2020-12-15 3:00 ` Yoshihiro Shimoda
2020-12-15 5:03 ` Yoshihiro Shimoda
2020-12-15 10:40 ` Wolfram Sang
2020-12-16 8:00 ` Yoshihiro Shimoda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TY2PR01MB3692DA2619361C6A23838259D8C50@TY2PR01MB3692.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.