RE: [PATCH v3 0/4] dmaengine: rcar-dmac: Add support for R-Car V3U

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
	Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3 0/4] dmaengine: rcar-dmac: Add support for R-Car V3U
Date: Fri, 29 Jan 2021 08:40:07 +0000	[thread overview]
Message-ID: <TY2PR01MB3692DFF3B6E414A901ABF30FD8B99@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20210128084455.2237256-1-geert+renesas@glider.be>

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Thursday, January 28, 2021 5:45 PM
> 
> 	Hi Vinod,
> 
> This patch series adds support for the Direct Memory Access Controller
> variant in the Renesas R-Car V3U (R8A779A0) SoC, to both DT bindings and
> driver.
> 
> Changes compared to v2:
>   - Add Reviewed-by, Tested-by,
>   - Place iterator after container being iterated,
>   - Stop passing index to rcar_dmac_chan_probe().
> 
> Changes compared to v1:
>   - Add Reviewed-by,
>   - Put the full loop control of for_each_rcar_dmac_chan() on a single
>     line, to improve readability,
>   - Use two separate named regions instead of array,
>   - Drop rcar_dmac_of_data.chan_reg_block, check for
>     !rcar_dmac_of_data.chan_offset_base instead,
>   - Precalculate chan_base in rcar_dmac_probe().
> 
> This has been tested on the Renesas Falcon board, using external SPI
> loopback (spi-loopback-test) on MSIOF1 and MSIOF2.

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Also, I tested on H3 Salvator-XS and the Falcon board with dmatest driver.
So,

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda