From: Biju Das <biju.das@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: RE: [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove audio port node
Date: Tue, 8 Oct 2019 13:43:24 +0000 [thread overview]
Message-ID: <TYAPR01MB21111CD187E5EF5CB6FB01BAB89A0@TYAPR01MB2111.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdWCu14DOci-EUuSZ_JTeZaoq90qr035WFsLY2c3UqgkeA@mail.gmail.com>
Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove audio
> port node
>
> Hi Biju,
>
> Thanks for your patch!
>
> On Fri, Oct 4, 2019 at 4:53 PM Biju Das <biju.das@bp.renesas.com> wrote:
> > This patch removes audio port node from SoC device tree.
>
> Standard review comment: "Why?"
>
> > Fixes: e2f04248fcd4 ("arm64: dts: renesas: r8a774a1: Add audio
> > support")
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > ---
> > V1-->V2
> > * New patch.
> > V2-->V3
> > * Fixed the commit message. Thanks to Fabrizio.
> >
> > This patch depend upon
> > https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=18
> > 2581
>
> Why the dependency?
> This looks like a fix for r8a774a1, too?
Sorry, the above dependency is for the second patch.
"[v3,2/2] arm64: dts: renesas: r8a774b1: Add Sound and Audio DMAC device nodes"
Regards,
Biju
> > ---
> > arch/arm64/boot/dts/renesas/hihope-common.dtsi | 20 +++++++++-------
> ----
> > arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 11 -----------
> > 2 files changed, 9 insertions(+), 22 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > index 355d0a2..2c942a7 100644
> > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > @@ -86,7 +86,7 @@
> >
> > label = "rcar-sound";
> >
> > - dais = <&rsnd_port0>;
> > + dais = <&rsnd_port>;
> > };
> >
> > vbus0_usb2: regulator-vbus0-usb2 { @@ -183,7 +183,7 @@
> > port@2 {
> > reg = <2>;
> > dw_hdmi0_snd_in: endpoint {
> > - remote-endpoint = <&rsnd_endpoint0>;
> > + remote-endpoint = <&rsnd_endpoint>;
> > };
> > };
> > };
> > @@ -319,17 +319,15 @@
> > /* Single DAI */
> > #sound-dai-cells = <0>;
> >
> > - ports {
> > - rsnd_port0: port@0 {
> > - rsnd_endpoint0: endpoint {
> > - remote-endpoint = <&dw_hdmi0_snd_in>;
> > + rsnd_port: port {
> > + rsnd_endpoint: endpoint {
> > + remote-endpoint = <&dw_hdmi0_snd_in>;
> >
> > - dai-format = "i2s";
> > - bitclock-master = <&rsnd_endpoint0>;
> > - frame-master = <&rsnd_endpoint0>;
> > + dai-format = "i2s";
> > + bitclock-master = <&rsnd_endpoint>;
> > + frame-master = <&rsnd_endpoint>;
> >
> > - playback = <&ssi2>;
> > - };
> > + playback = <&ssi2>;
> > };
> > };
> > };
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > index d179ee3..34a9f47 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > @@ -1726,17 +1726,6 @@
> > "ssi.1", "ssi.0";
> > status = "disabled";
> >
> > - ports {
> > - #address-cells = <1>;
> > - #size-cells = <0>;
> > - port@0 {
> > - reg = <0>;
> > - };
> > - port@1 {
> > - reg = <1>;
> > - };
> > - };
> > -
> > rcar_sound,ctu {
> > ctu00: ctu-0 { };
> > ctu01: ctu-1 { };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2019-10-08 13:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 14:52 [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove audio port node Biju Das
2019-10-04 14:52 ` [PATCH v3 2/2] arm64: dts: renesas: r8a774b1: Add Sound and Audio DMAC device nodes Biju Das
2019-10-09 14:46 ` Geert Uytterhoeven
2019-10-08 13:21 ` [PATCH v3 1/2] arm64: dts: renesas: r8a774a1: Remove audio port node Geert Uytterhoeven
2019-10-08 13:43 ` Biju Das [this message]
2019-10-10 12:56 ` Geert Uytterhoeven
2019-10-10 13:04 ` Biju Das
2019-10-10 13:19 ` Geert Uytterhoeven
2019-10-10 14:01 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB21111CD187E5EF5CB6FB01BAB89A0@TYAPR01MB2111.jpnprd01.prod.outlook.com \
--to=biju.das@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.