RE: [PATCH v12 03/19] PCI: Add PCI_HEADER_TYPE_MULTI_FUNC

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
	"mani@kernel.org" <mani@kernel.org>,
	"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
	"fancer.lancer@gmail.com" <fancer.lancer@gmail.com>,
	"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"kw@linux.com" <kw@linux.com>,
	"bhelgaas@google.com" <bhelgaas@google.com>,
	"kishon@kernel.org" <kishon@kernel.org>,
	"marek.vasut+renesas@gmail.com" <marek.vasut+renesas@gmail.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH v12 03/19] PCI: Add PCI_HEADER_TYPE_MULTI_FUNC
Date: Mon, 17 Apr 2023 04:51:58 +0000	[thread overview]
Message-ID: <TYBPR01MB53418E476ED24B2BA922B7B2D89C9@TYBPR01MB5341.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20230414185812.GA212427@bhelgaas>

Hi Bjorn,

> From: Bjorn Helgaas, Sent: Saturday, April 15, 2023 3:58 AM
> 
> On Fri, Apr 14, 2023 at 03:16:06PM +0900, Yoshihiro Shimoda wrote:
> > Add PCI_HEADER_TYPE_MULTI_FUNC macro which is "Multi-Function Device"
> > of Header Type Register.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > ---
> >  include/uapi/linux/pci_regs.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/include/uapi/linux/pci_regs.h b/include/uapi/linux/pci_regs.h
> > index 5d48413ac28f..a302b67d2834 100644
> > --- a/include/uapi/linux/pci_regs.h
> > +++ b/include/uapi/linux/pci_regs.h
> > @@ -80,6 +80,7 @@
> >  #define  PCI_HEADER_TYPE_NORMAL		0
> >  #define  PCI_HEADER_TYPE_BRIDGE		1
> >  #define  PCI_HEADER_TYPE_CARDBUS	2
> > +#define  PCI_HEADER_TYPE_MULTI_FUNC	0x80
> 
> We test this a few places already; if we add this new macro, shouldn't
> we update those places to use it?

Thank you for your comment! We should updated drivers/pci/{probe,quirks}.c
like the following code for example:

	dev->multifunction = !!(hdr_type & 0x80);

I'll update them on v13.

Best regards,
Yoshihiro Shimoda

> >  #define PCI_BIST		0x0f	/* 8 bits */
> >  #define  PCI_BIST_CODE_MASK	0x0f	/* Return result */
> > --
> > 2.25.1
> >