From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Greg KH <gregkh@linuxfoundation.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: RE: [PATCH v2 6/7] arm64: dts: renesas: Add Renesas R8A779G0 SoC support
Date: Thu, 28 Apr 2022 07:27:14 +0000 [thread overview]
Message-ID: <TYBPR01MB53419EA31C68FBFAD8A3CC59D8FD9@TYBPR01MB5341.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdVffc4iqX6wAKwyq_eTX5c0H3-tqs_pvsec7v1_q6hS3g@mail.gmail.com>
Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Wednesday, April 27, 2022 11:37 PM
>
> On Mon, Apr 25, 2022 at 8:42 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > Add initial support for the Renesas R8A779G0 (R-Car V4H) SoC.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> Thanks for your patch!
Thank you for your review!
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi
>
> > + soc: soc {
>
> > + hscif0: serial@e6540000 {
> > + compatible = "renesas,hscif-r8a779g0",
> > + "renesas,rcar-gen4-hscif",
> > + "renesas,hscif";
> > + reg = <0 0xe6540000 0 96>;
> > + interrupts = <GIC_SPI 246 IRQ_TYPE_LEVEL_HIGH>;
>
> 245
Oops! I'll fix it.
> > + clocks = <&cpg CPG_MOD 514>,
> > + <&cpg CPG_CORE R8A779G0_CLK_S0D3_PER>,
> > + <&scif_clk>;
> > + clock-names = "fck", "brg_int", "scif_clk";
> > + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>;
> > + resets = <&cpg 514>;
> > + status = "disabled";
> > + };
>
> The rest LGTM, so with the above fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thank you for your review!
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2022-04-28 7:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 6:41 [PATCH v2 0/7] treewide: Initial support for R-Car V4H Yoshihiro Shimoda
2022-04-25 6:41 ` [PATCH v2 1/7] dt-bindings: power: Add r8a779g0 SYSC power domain definitions Yoshihiro Shimoda
2022-04-25 6:41 ` [PATCH v2 2/7] dt-bindings: clock: Add r8a779g0 CPG Core Clock Definitions Yoshihiro Shimoda
2022-04-25 8:26 ` Geert Uytterhoeven
2022-04-25 18:39 ` Krzysztof Kozlowski
2022-04-25 6:41 ` [PATCH v2 3/7] dt-bindings: serial: renesas,hscif: Document r8a779g0 bindings Yoshihiro Shimoda
2022-04-25 8:13 ` Geert Uytterhoeven
2022-04-25 6:41 ` [PATCH v2 4/7] clk: renesas: rcar-gen4: Add CLK_TYPE_GEN4_PLL4 Yoshihiro Shimoda
2022-04-25 14:48 ` Geert Uytterhoeven
2022-04-25 6:41 ` [PATCH v2 5/7] clk: renesas: cpg-mssr: Add support for R-Car V4H Yoshihiro Shimoda
2022-04-27 14:26 ` Geert Uytterhoeven
2022-04-28 7:16 ` Yoshihiro Shimoda
2022-04-25 6:42 ` [PATCH v2 6/7] arm64: dts: renesas: Add Renesas R8A779G0 SoC support Yoshihiro Shimoda
2022-04-27 14:37 ` Geert Uytterhoeven
2022-04-28 7:27 ` Yoshihiro Shimoda [this message]
2022-04-25 6:42 ` [PATCH v2 7/7] arm64: dts: renesas: Add Renesas White Hawk boards support Yoshihiro Shimoda
2022-04-27 14:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYBPR01MB53419EA31C68FBFAD8A3CC59D8FD9@TYBPR01MB5341.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.