RE: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt handler

From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Stephen Boyd <swboyd@chromium.org>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	"linux-renesas-soc@vger.kernel.org" 
	<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt handler
Date: Fri, 17 Mar 2023 08:08:41 +0000	[thread overview]
Message-ID: <TYCPR01MB593390150CAC755AE540D7D586BD9@TYCPR01MB5933.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdUN=0aJ-7huv0XrhG3LMu8q_SEuqHU48ytTgGAYEjng5A@mail.gmail.com>

Hi Geert,

> Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt handler
> 
> Hi Biju,
> 
> On Fri, Mar 17, 2023 at 8:59 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > > Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt
> > > handler On Thu, Mar 16, 2023 at 5:34 PM Biju Das
> <biju.das.jz@bp.renesas.com> wrote:
> > > > > Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end
> > > > > interrupt handler
> > >
> > > > > On Thu, Mar 16, 2023 at 5:01 PM Biju Das
> > > > > <biju.das.jz@bp.renesas.com>
> > > wrote:
> > > > > > The RZ SCI/ RZ/A1 SCIF has only 4 interrupts. The fourth
> > > > > > interrupt is transmit end interrupt, so shuffle the interrupts
> > > > > > to fix the transmit end interrupt handler for these IPs.
> > > > > >
> > > > > > Fixes: 392fb8df528b ("serial: sh-sci: Use
> > > > > > platform_get_irq_optional() for optional interrupts")
> > > > >
> > > > > I don't think that's the right bad commit.
> > > >
> > > > OK. I will use below commit as fixes one, that is the commit which
> > > > added RZ/A1 SCIF with 4 interrupts.
> > > >
> > > > commit 8b0bbd956228ae87 ("serial: sh-sci: Add support for
> > > > R7S9210")
> > >
> > > That one added support for RZ/A2, and is also not the bad commit?
> >
> > OK will use below one,
> >
> > Fixes: 4c84c1b3acca ("ARM: shmobile: r7s72100: add scif nodes to
> > dtsi")
> 
> This really starts to look like a guessing game... Beep ;-)

Already there is a generic compatible in driver, where we started introducing RZ/A1 SoC
With 4 interrupts. So addition of this SoC has this issue. Am I missing anything here?

Please let me know.

Cheers,
Biju