RE: [PATCH 5.10.y-cip] tty: serial: sh-sci: Fix sleeping in atomic context

From: <nobuhiro1.iwamatsu@toshiba.co.jp>
To: <biju.das.jz@bp.renesas.com>, <cip-dev@lists.cip-project.org>,
	<pavel@denx.de>
Cc: <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH 5.10.y-cip] tty: serial: sh-sci: Fix sleeping in atomic context
Date: Thu, 3 Aug 2023 04:45:51 +0000	[thread overview]
Message-ID: <TYWPR01MB9420153CA8F61FAFB8310E949208A@TYWPR01MB9420.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20230802144856.578404-1-biju.das.jz@bp.renesas.com>

Hi,

> -----Original Message-----
> From: Biju Das <biju.das.jz@bp.renesas.com>
> Sent: Wednesday, August 2, 2023 11:49 PM
> To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□
> ＤＩＴ○ＯＳＴ) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>
> Cc: Biju Das <biju.das.jz@bp.renesas.com>; Lad Prabhakar
> <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH 5.10.y-cip] tty: serial: sh-sci: Fix sleeping in atomic context
> 
> commit 57c984f6fe20ebb9306d6e8c09b4f67fe63298c6 upstream.
> 
> Fix sleeping in atomic context warning as reported by the Smatch static
> checker tool by replacing disable_irq->disable_irq_nosync.
> 
> Reported by: Dan Carpenter <dan.carpenter@linaro.org>
> 
> Fixes: 8749061be196 ("tty: serial: sh-sci: Add RZ/G2L SCIFA DMA tx support")
> Cc: stable@kernel.org
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Link:
> https://lore.kernel.org/r/20230704154818.406913-1-biju.das.jz@bp.renesas.c
> om
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  drivers/tty/serial/sh-sci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index
> 774762143f4e..cde5f8bf4111 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -590,7 +590,7 @@ static void sci_start_tx(struct uart_port *port)
>  	    dma_submit_error(s->cookie_tx)) {
>  		if (s->cfg->regtype == SCIx_RZ_SCIFA_REGTYPE)
>  			/* Switch irq from SCIF to DMA */
> -			disable_irq(s->irqs[SCIx_TXI_IRQ]);
> +			disable_irq_nosync(s->irqs[SCIx_TXI_IRQ]);
> 
>  		s->cookie_tx = 0;
>  		schedule_work(&s->work_tx);
> --
> 2.25.1

LGTM. I can apply if there are no comments.

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro