From: "Horia Geantă" <horia.geanta@nxp.com>
To: Tudor Ambarus <tudor.ambarus@microchip.com>,
Robert Baronescu <robert.baronescu@nxp.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed()
Date: Tue, 14 Nov 2017 10:02:54 +0000 [thread overview]
Message-ID: <VI1PR0402MB334266444B0B9A93141F894798280@VI1PR0402MB3342.eurprd04.prod.outlook.com> (raw)
In-Reply-To: c0079a24-d338-76f0-2957-1d3727e966fc@microchip.com
On 11/13/2017 8:24 PM, Tudor Ambarus wrote:
> Hi,
>
> On 10/10/2017 01:21 PM, Robert Baronescu wrote:
>> In case buffer length is a multiple of PAGE_SIZE,
>> the S/G table is incorrectly generated.
>> Fix this by handling buflen = k * PAGE_SIZE separately.
>>
>> Signed-off-by: Robert Baronescu <robert.baronescu@nxp.com>
>> ---
>> crypto/tcrypt.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> This patch fixes the segmentation fault listed below. The NULL
> dereference can be seen starting with:
> 7aacbfc crypto: tcrypt - fix buffer lengths in test_aead_speed()
>
Right, the order of the two fixes is unfortunate in the sense that first
fix (commit 7aacbfc) uncovers the issue you mention.
Thanks,
Horia
next prev parent reply other threads:[~2017-11-14 10:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 10:21 [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed() Robert Baronescu
2017-10-10 10:22 ` [PATCH 2/2] crypto: tcrypt - fix buffer lengths in test_aead_speed() Robert Baronescu
2017-11-03 14:22 ` Herbert Xu
2017-11-03 12:41 ` [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed() Herbert Xu
2017-11-09 14:37 ` Horia Geantă
2017-11-09 22:21 ` Herbert Xu
2017-11-10 6:37 ` Horia Geantă
2017-11-10 7:43 ` Herbert Xu
2017-11-10 9:17 ` Horia Geantă
2017-11-10 10:41 ` Herbert Xu
2017-11-12 16:26 ` Horia Geantă
2017-11-13 18:27 ` Tudor Ambarus
2017-11-14 10:41 ` Horia Geantă
2017-11-14 14:59 ` [PATCH] crypto: tcrypt - set assoc in sg_init_aead() Tudor Ambarus
2017-11-15 9:11 ` Horia Geantă
2017-11-29 6:36 ` Herbert Xu
2017-11-14 10:45 ` [PATCH 1/2] crypto: tcrypt - fix S/G table for test_aead_speed() Herbert Xu
2017-11-13 18:24 ` Tudor Ambarus
2017-11-14 10:02 ` Horia Geantă [this message]
2017-11-29 6:28 ` [1/2] " Herbert Xu
2017-11-29 8:57 ` Horia Geantă
2017-11-29 10:23 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB334266444B0B9A93141F894798280@VI1PR0402MB3342.eurprd04.prod.outlook.com \
--to=horia.geanta@nxp.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=robert.baronescu@nxp.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.