From: Horia Geanta <horia.geanta@nxp.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc: Chris Healy <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
Iuliana Prodan <iuliana.prodan@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v7 6/9] crypto: caam - check if RNG job failed
Date: Wed, 12 Feb 2020 10:41:21 +0000 [thread overview]
Message-ID: <VI1PR0402MB34857006B42E8F0DAFECC514981B0@VI1PR0402MB3485.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 20200127165646.19806-7-andrew.smirnov@gmail.com
On 1/27/2020 6:57 PM, Andrey Smirnov wrote:
> @@ -60,12 +65,12 @@ static struct caam_rng_ctx *to_caam_rng_ctx(struct hwrng *r)
> static void caam_rng_done(struct device *jrdev, u32 *desc, u32 err,
> void *context)
> {
> - struct completion *done = context;
> + struct caam_rng_job_ctx *jctx = context;
>
> if (err)
> - caam_jr_strstatus(jrdev, err);
> + *jctx->err = caam_jr_strstatus(jrdev, err);
>
> - complete(done);
> + complete(jctx->done);
> }
>
> static u32 *caam_init_desc(u32 *desc, dma_addr_t dst_dma, int len)
> @@ -89,6 +94,10 @@ static int caam_rng_read_one(struct device *jrdev,
> {
> dma_addr_t dst_dma;
> int err;
> + struct caam_rng_job_ctx jctx = {
> + .done = done,
> + .err = &err,
> + };
>
> len = min_t(int, len, CAAM_RNG_MAX_FIFO_STORE_SIZE);
>
> @@ -101,7 +110,7 @@ static int caam_rng_read_one(struct device *jrdev,
> init_completion(done);
> err = caam_jr_enqueue(jrdev,
> caam_init_desc(desc, dst_dma, len),
> - caam_rng_done, done);
> + caam_rng_done, &jctx);
AFAICT there's a race condition b/w caam_jr_enqueue() and caam_rng_done(),
both writing to "err":
caam_jr_enqueue()
-> JR interrupt -> caam_jr_interrupt() -> tasklet_schedule()...
-> spin_unlock_bh()
-> caam_jr_dequeue() -> caam_rng_done() -> write err
-> return 0 -> write err
Horia
next prev parent reply other threads:[~2020-02-12 10:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 16:56 [PATCH v7 0/9] enable CAAM's HWRNG as default Andrey Smirnov
2020-01-27 16:56 ` [PATCH v7 1/9] crypto: caam - allocate RNG instantiation descriptor with GFP_DMA Andrey Smirnov
2020-02-04 14:08 ` Horia Geanta
2020-02-24 16:40 ` Andrey Smirnov
2020-03-16 4:14 ` Andrey Smirnov
2020-03-17 15:20 ` Horia Geantă
2020-01-27 16:56 ` [PATCH v7 2/9] crypto: caam - use struct hwrng's .init for initialization Andrey Smirnov
2020-02-11 14:39 ` Horia Geanta
2020-01-27 16:56 ` [PATCH v7 3/9] crypto: caam - use devm_kzalloc to allocate JR data Andrey Smirnov
2020-02-11 18:23 ` Horia Geanta
2020-02-24 16:39 ` Andrey Smirnov
2020-01-27 16:56 ` [PATCH v7 4/9] crypto: caam - drop global context pointer and init_done Andrey Smirnov
2020-02-11 18:53 ` Horia Geanta
2020-02-11 20:57 ` Horia Geanta
2020-02-24 16:40 ` Andrey Smirnov
2020-01-27 16:56 ` [PATCH v7 5/9] crypto: caam - simplify RNG implementation Andrey Smirnov
2020-02-12 13:20 ` Horia Geanta
2020-02-24 17:16 ` Andrey Smirnov
2020-01-27 16:56 ` [PATCH v7 6/9] crypto: caam - check if RNG job failed Andrey Smirnov
2020-02-12 10:41 ` Horia Geanta [this message]
2020-02-24 16:37 ` Andrey Smirnov
2020-01-27 16:56 ` [PATCH v7 7/9] crypto: caam - invalidate entropy register during RNG initialization Andrey Smirnov
2020-02-25 20:26 ` Horia Geanta
2020-01-27 16:56 ` [PATCH v7 8/9] crypto: caam - enable prediction resistance in HRWNG Andrey Smirnov
2020-02-04 13:09 ` [EXT] " Andrei Botila (OSS)
2020-02-04 14:19 ` Horia Geanta
2020-01-27 16:56 ` [PATCH v7 9/9] crypto: caam - limit single JD RNG output to maximum of 16 bytes Andrey Smirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR0402MB34857006B42E8F0DAFECC514981B0@VI1PR0402MB3485.eurprd04.prod.outlook.com \
--to=horia.geanta@nxp.com \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=iuliana.prodan@nxp.com \
--cc=l.stach@pengutronix.de \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.