From: Andrew Lunn <andrew@lunn.ch>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set
Date: Mon, 4 Jan 2021 18:31:05 +0100 [thread overview]
Message-ID: <X/NQ2fYdBygm3CYc@lunn.ch> (raw)
In-Reply-To: <X/NNS3FUeSNxbqwo@lunn.ch>
> The basic rules here should be, if the MDIO bus is registered, it is
> usable. There are things like PHY statistics, HWMON temperature
> sensors, etc, DSA switches, all which have a life cycle separate to
> the interface being up.
[Goes and looks at the code]
Yes, this is runtime PM which is broken.
sh_mdio_init() needs to wrap the mdp->mii_bus->read and
mdp->mii_bus->write calls with calls to
pm_runtime_get_sync(&mdp->pdev->dev);
and
pm_runtime_put_sync(&mdp->pdev->dev);
The KSZ8041RNLI supports statistics, which ethtool --phy-stats can
read, and these will also going to cause problems.
Andrew
next prev parent reply other threads:[~2021-01-04 17:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 12:24 [PATCH] [RFC] net: phy: Fix reboot crash if CONFIG_IP_PNP is not set Geert Uytterhoeven
2021-01-04 14:53 ` Ioana Ciornei
2021-01-04 15:11 ` Geert Uytterhoeven
2021-01-04 17:01 ` Ioana Ciornei
2021-01-04 17:15 ` Andrew Lunn
2021-01-04 17:31 ` Andrew Lunn [this message]
2021-01-04 18:43 ` Ioana Ciornei
2021-01-04 21:30 ` Florian Fainelli
2021-01-05 10:01 ` Geert Uytterhoeven
2021-01-05 14:10 ` Andrew Lunn
2021-01-13 9:02 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/NQ2fYdBygm3CYc@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.