From: Andrew Lunn <andrew@lunn.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: stefanc@marvell.com, netdev@vger.kernel.org,
thomas.petazzoni@bootlin.com, davem@davemloft.net,
nadavh@marvell.com, ymarkman@marvell.com,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
mw@semihalf.com, rmk+kernel@armlinux.org.uk, atenart@kernel.org
Subject: Re: [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support
Date: Tue, 12 Jan 2021 01:47:27 +0100 [thread overview]
Message-ID: <X/zxnyyTRf0xsYmd@lunn.ch> (raw)
In-Reply-To: <20210111163653.6483ae82@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, Jan 11, 2021 at 04:36:53PM -0800, Jakub Kicinski wrote:
> On Sun, 10 Jan 2021 21:23:02 +0200 stefanc@marvell.com wrote:
> > From: Stefan Chulski <stefanc@marvell.com>
> >
> > Packet Processor hardware not connected to MAC flow control unit and
> > cannot support TX flow control.
> > This patch disable flow control support.
> >
> > Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
> > Signed-off-by: Stefan Chulski <stefanc@marvell.com>
>
> I'm probably missing something, but why not 4bb043262878 ("net: mvpp2:
> phylink support")?
Hi Jakub
Before that change, it used phylib. The same is true with phylib, you
need to tell phylib it should not advertise pause. How you do it is
different, but the basic issue is the same. Anybody doing a backport
past 4bb043262878is going to need a different fix, but the basic issue
is there all the way back to when the driver was added.
Andrew
next prev parent reply other threads:[~2021-01-12 0:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 19:23 [PATCH net ] net: mvpp2: Remove Pause and Asym_Pause support stefanc
2021-01-11 11:11 ` Marcin Wojtas
2021-01-12 0:36 ` Jakub Kicinski
2021-01-12 0:47 ` Andrew Lunn [this message]
2021-01-12 0:57 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/zxnyyTRf0xsYmd@lunn.ch \
--to=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.