From: Daniel Vetter <daniel@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 2/2] drm/fb-helper: Add a FIXME that generic_setup is very confusing
Date: Tue, 22 Dec 2020 09:55:28 +0100 [thread overview]
Message-ID: <X+G0gDNlSCGLyjGK@phenom.ffwll.local> (raw)
In-Reply-To: <20201211161113.3350061-2-daniel.vetter@ffwll.ch>
On Fri, Dec 11, 2020 at 05:11:13PM +0100, Daniel Vetter wrote:
> I tried to fix this for real, but it's very sprawling and lots of
> drivers get this mildly wrong one way or the other.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
Anyone feeling like an ack on this one?
-Daniel
> ---
> drivers/gpu/drm/drm_fb_helper.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c
> index 596255edf023..27deed4af015 100644
> --- a/drivers/gpu/drm/drm_fb_helper.c
> +++ b/drivers/gpu/drm/drm_fb_helper.c
> @@ -2494,6 +2494,11 @@ void drm_fbdev_generic_setup(struct drm_device *dev,
> return;
> }
>
> + /*
> + * FIXME: This mixes up depth with bpp, which results in a glorious
> + * mess, resulting in some drivers picking wrong fbdev defaults and
> + * others wrong preferred_depth defaults.
> + */
> if (!preferred_bpp)
> preferred_bpp = dev->mode_config.preferred_depth;
> if (!preferred_bpp)
> --
> 2.29.2
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-22 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 16:11 [PATCH 1/2] drm/vkms: Unset preferred_depth Daniel Vetter
2020-12-11 16:11 ` [PATCH 2/2] drm/fb-helper: Add a FIXME that generic_setup is very confusing Daniel Vetter
2020-12-22 8:55 ` Daniel Vetter [this message]
2020-12-22 9:00 ` Simon Ser
2020-12-22 11:18 ` Daniel Vetter
2020-12-23 14:46 ` Maxime Ripard
2020-12-11 16:21 ` [PATCH 1/2] drm/vkms: Unset preferred_depth Ville Syrjälä
2020-12-11 16:25 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+G0gDNlSCGLyjGK@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.