From: Greg KH <gregkh@linuxfoundation.org>
To: Zhang Qilong <zhangqilong3@huawei.com>
Cc: devel@driverdev.osuosl.org, elder@kernel.org,
vaibhav.sr@gmail.com, johan@kernel.org, mgreer@animalcreek.com,
greybus-dev@lists.linaro.org
Subject: Re: [PATCH 2/2] staging: greybus: audio: apbridgea: Fix reference counter leak in error handling
Date: Sat, 14 Nov 2020 00:27:28 +0100 [thread overview]
Message-ID: <X68WYE+7tcytXhFG@kroah.com> (raw)
In-Reply-To: <20201109131347.1725288-3-zhangqilong3@huawei.com>
On Mon, Nov 09, 2020 at 09:13:47PM +0800, Zhang Qilong wrote:
> When gb_audio_apbridgea_register_cport failed, maybe:
>
> 1) gb_pm_runtime_get_sync failed, usage counter remained unchanged;
>
> 2) gb_hd_output failed, usage counter remained increased;
>
> In error state, there are two different states in usage cpounter. So,
> if gb_hd_output failed, we should call gb_pm_runtime_put_autosuspend
> ot decrease usage counter for balabce preventing reference leak. And
> we fixed it by add gb_pm_runtime_put_autosuspend when gb_hd_output
> failed.
>
> Fixes: 6ba7fad430d63 ("Add runtime pm support to audio protocol device class driver.")
That is not the name for that git commit id :(
Please fix up and resend.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2020-11-13 23:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 13:13 [PATCH 0/2] Fix reference counter leak in error banch Zhang Qilong
2020-11-09 13:13 ` [PATCH 1/2] staging: greybus: codecs: Fix reference counter leak in error handling Zhang Qilong
2020-11-09 13:13 ` [PATCH 2/2] greybus: audio: apbridgea: " Zhang Qilong
2020-11-13 23:27 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X68WYE+7tcytXhFG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
--cc=zhangqilong3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.