From: "Krzysztof Wilczyński" <kw@linux.com>
To: Wang Hai <wanghai38@huawei.com>
Cc: Jisheng.Zhang@synaptics.com, jingoohan1@gmail.com,
gustavo.pimentel@synopsys.com, lorenzo.pieralisi@arm.com,
robh@kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: dwc: fix error return code in dw_pcie_host_init()
Date: Thu, 19 Nov 2020 17:02:35 +0100 [thread overview]
Message-ID: <X7aXG6kC5zZWlpqg@rocinante> (raw)
In-Reply-To: <20201117064142.32903-1-wanghai38@huawei.com>
Hi Hai,
Thank you for taking care about this.
On 20-11-17 14:41:42, Wang Hai wrote:
I would have to ask you to capitalise the first letter in the subject
line as it has been done for other patches. Check Git history to see
what it normally would look like.
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
The above commit message was taken from the first patch, and might not
be accurate any more. As now you are passing an error code from the
dma_mapping_error() function rather than just setting the ret variable.
Also, the ret variable might have either undetermined value or some
other value from previous assignment, not necessarily 0 there.
Krzysztof
prev parent reply other threads:[~2020-11-19 16:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 6:41 [PATCH v2] PCI: dwc: fix error return code in dw_pcie_host_init() Wang Hai
2020-11-17 6:56 ` Jisheng Zhang
2020-11-19 16:02 ` Krzysztof Wilczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7aXG6kC5zZWlpqg@rocinante \
--to=kw@linux.com \
--cc=Jisheng.Zhang@synaptics.com \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.