From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rafael@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Zhang Rui <rui.zhang@intel.com>,
Len Brown <lenb@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Raju Rangoju <rajur@chelsio.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Gregory Greenman <gregory.greenman@intel.com>,
Kalle Valo <kvalo@kernel.org>, Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Amit Kucheria <amitk@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Markus Mayer <mmayer@broadcom.com>,
Support Opensource <support.opensource@diasemi.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Vasily Khoruzhick <anarsoul@gmail.com>,
Yangtao Li <tiny.windzz@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Talel Shenhar <talel@amazon.com>,
Eduardo Valentin <edubezval@gmail.com>,
Keerthy <j-keerthy@ti.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
ye xingchen <ye.xingchen@zte.com.cn>,
Zheng Yongjun <zhengyongjun3@huawei.com>,
Tim Zimmermann <tim@linux4.de>,
Yang Li <yang.lee@linux.alibaba.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
Jiang Jian <jiangjian@cdjrlc.com>,
Daniel Golle <daniel@makrotopia.org>,
Balsam CHIHI <bchihi@baylibre.com>,
Randy Dunlap <rdunlap@infradead.org>,
Mikko Perttunen <mperttunen@nvidia.com>,
"open list:ACPI THERMAL DRIVER" <linux-acpi@vger.kernel.org>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list:ARM/Allwinner sunXi SoC support"
<linux-sunxi@lists.linux.dev>,
"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK,
TOUCHSCREEN)..." <linux-input@vger.kernel.org>,
"open list:CXGB4 ETHERNET DRIVER (CXGB4)"
<netdev@vger.kernel.org>,
"open list:INTEL WIRELESS WIFI LINK (iwlwifi)"
<linux-wireless@vger.kernel.org>,
"moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE"
<linux-rpi-kernel@lists.infradead.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
"open list:RENESAS R-CAR THERMAL DRIVERS"
<linux-renesas-soc@vger.kernel.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>,
"open list:SAMSUNG THERMAL DRIVER"
<linux-samsung-soc@vger.kernel.org>,
"open list:TEGRA ARCHITECTURE SUPPORT"
<linux-tegra@vger.kernel.org>,
"open list:TI BANDGAP AND THERMAL DRIVER"
<linux-omap@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v1 01/17] thermal/core: Add a thermal zone 'devdata' accessor
Date: Sun, 19 Feb 2023 16:07:20 +0100 [thread overview]
Message-ID: <Y/I7KA2Uqqk7ib6L@oden.dyn.berto.se> (raw)
In-Reply-To: <20230219143657.241542-2-daniel.lezcano@linaro.org>
Hi Daniel,
Thanks for your work.
On 2023-02-19 15:36:41 +0100, Daniel Lezcano wrote:
> The thermal zone device structure is exposed to the different drivers
> and obviously they access the internals while that should be
> restricted to the core thermal code.
>
> In order to self-encapsulate the thermal core code, we need to prevent
> the drivers accessing directly the thermal zone structure and provide
> accessor functions to deal with.
>
> Provide an accessor to the 'devdata' structure and make use of it in
> the different drivers.
>
> No functional changes intended.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
...
> drivers/thermal/rcar_gen3_thermal.c | 4 ++--
> drivers/thermal/rcar_thermal.c | 3 +--
For R-Car,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
...
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index 2bb4bf33f4f3..724b95662da9 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -365,6 +365,8 @@ thermal_zone_device_register_with_trips(const char *, struct thermal_trip *, int
> void *, struct thermal_zone_device_ops *,
> struct thermal_zone_params *, int, int);
>
> +void *thermal_zone_device_get_data(struct thermal_zone_device *tzd);
> +
bikeshedding:
Would it make sens to name this thermal_zone_device_get_priv_data(),
thermal_zone_device_get_priv() or something like that? To make it more
explicitly when reading the driver code this fetches the drivers private
data, and not some data belonging to the zone itself.
> int thermal_zone_bind_cooling_device(struct thermal_zone_device *, int,
> struct thermal_cooling_device *,
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2023-02-19 15:07 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 14:36 [PATCH v1 00/17] Self-encapsulate the thermal zone device structure Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 01/17] thermal/core: Add a thermal zone 'devdata' accessor Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-19 14:56 ` Guenter Roeck
2023-02-19 15:07 ` Niklas Söderlund [this message]
2023-02-19 17:07 ` Daniel Lezcano
2023-02-19 18:23 ` Niklas Söderlund
2023-02-19 16:23 ` kernel test robot
2023-02-19 22:34 ` Mark Brown
2023-02-20 8:20 ` Ido Schimmel
2023-02-20 9:09 ` AngeloGioacchino Del Regno
2023-02-20 10:34 ` Balsam CHIHI
2023-02-20 10:37 ` Greenman, Gregory
2023-02-20 11:03 ` DLG Adam Ward
2023-02-20 12:18 ` Geert Uytterhoeven
2023-02-20 14:48 ` DLG Adam Ward
2023-02-20 11:13 ` Baolin Wang
2023-02-20 13:23 ` Sebastian Reichel
2023-02-25 17:03 ` Jonathan Cameron
2023-02-19 14:36 ` [PATCH v1 02/17] thermal/core: Show a debug message when get_temp() fails Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 03/17] thermal: Remove debug or error messages in get_temp() ops Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-20 8:58 ` Miquel Raynal
2023-02-20 8:58 ` Miquel Raynal
2023-02-20 8:58 ` Miquel Raynal
2023-02-19 14:36 ` [PATCH v1 04/17] thermal/hwmon: Do not set no_hwmon before calling thermal_add_hwmon_sysfs() Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-19 15:08 ` Niklas Söderlund
2023-02-19 15:08 ` Niklas Söderlund
2023-02-19 15:08 ` Niklas Söderlund
2023-02-19 14:36 ` [PATCH v1 05/17] thermal/hwmon: Use the right device for devm_thermal_add_hwmon_sysfs() Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-19 17:26 ` Martin Blumenstingl
2023-02-19 17:26 ` Martin Blumenstingl
2023-02-19 17:26 ` Martin Blumenstingl
2023-02-19 14:36 ` [PATCH v1 06/17] thermal: Don't use 'device' internal thermal zone structure field Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-20 10:50 ` Balsam CHIHI
2023-02-20 10:50 ` Balsam CHIHI
2023-02-19 14:36 ` [PATCH v1 07/17] thermal/hwmon: Use the thermal API instead tampering the internals Daniel Lezcano
2023-02-20 13:34 ` Daniel Lezcano
2023-02-20 14:11 ` Guenter Roeck
2023-02-20 15:39 ` Daniel Lezcano
2023-02-20 17:12 ` Guenter Roeck
2023-02-21 16:08 ` Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 08/17] thermal/drivers/spear: Don't use tz->device but pdev->dev Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 09/17] thermal: Add a thermal zone id accessor Daniel Lezcano
2023-02-19 14:55 ` Guenter Roeck
2023-02-19 17:15 ` kernel test robot
2023-02-19 14:36 ` [PATCH v1 10/17] thermal: Do not access 'type' field, use the tz id instead Daniel Lezcano
2023-02-19 14:36 ` Daniel Lezcano
2023-02-20 8:22 ` Ido Schimmel
2023-02-20 8:22 ` Ido Schimmel
2023-02-19 14:36 ` [PATCH v1 11/17] thermal/drivers/da9062: Don't access the thermal zone device fields Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 12/17] thermal/hwmon: Use the thermal_core.h header Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 13/17] thermal/drivers/tegra: Remove unneeded lock when setting a trip point Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 14/17] thermal/tegra: Do not enable the thermal zone, it is already enabled Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 15/17] thermal/drivers/acerhdf: Make interval setting only at module load time Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 16/17] thermal/drivers/acerhdf: Remove pointless governor test Daniel Lezcano
2023-02-19 14:36 ` [PATCH v1 17/17] thermal/traces: Replace the thermal zone structure parameter with the field value Daniel Lezcano
2023-02-19 21:35 ` [PATCH v1 16/17] thermal/drivers/acerhdf: Remove pointless governor test Peter Kästle
2023-02-19 21:38 ` [PATCH v1 15/17] thermal/drivers/acerhdf: Make interval setting only at module load time Peter Kästle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/I7KA2Uqqk7ib6L@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=amitk@kernel.org \
--cc=anarsoul@gmail.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bchihi@baylibre.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=bzolnier@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=edubezval@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=gregory.greenman@intel.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=heiko@sntech.de \
--cc=idosch@nvidia.com \
--cc=j-keerthy@ti.com \
--cc=jdelvare@suse.com \
--cc=jernej.skrabec@gmail.com \
--cc=jiangjian@cdjrlc.com \
--cc=jic23@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=lars@metafoo.de \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=mhiramat@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=mmayer@broadcom.com \
--cc=mperttunen@nvidia.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=rafael@kernel.org \
--cc=rajur@chelsio.com \
--cc=rdunlap@infradead.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=rjui@broadcom.com \
--cc=rui.zhang@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=stefan.wahren@i2se.com \
--cc=support.opensource@diasemi.com \
--cc=talel@amazon.com \
--cc=thara.gopinath@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tim@linux4.de \
--cc=tiny.windzz@gmail.com \
--cc=wens@csie.org \
--cc=yang.lee@linux.alibaba.com \
--cc=ye.xingchen@zte.com.cn \
--cc=zhang.lyra@gmail.com \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.