From: Herbert Xu <herbert@gondor.apana.org.au>
To: наб <nabijaczleweli@nabijaczleweli.xyz>
Cc: dash@vger.kernel.org
Subject: Re: [PATCH] Prototype all function definitions for C23 compat
Date: Thu, 9 Feb 2023 12:53:28 +0800 [thread overview]
Message-ID: <Y+R8SCX45HlQY8Xk@gondor.apana.org.au> (raw)
In-Reply-To: <20230207163439.d3fqmpyh6ak3wyhw@tarta.nabijaczleweli.xyz>
наб <nabijaczleweli@nabijaczleweli.xyz> wrote:
>
> STATIC int
> -describe_command(out, command, path, verbose)
> - struct output *out;
> - char *command;
> - const char *path;
> - int verbose;
> +describe_command(struct output *out, char *command, const char *path, int verbose)
Thanks for doing this!
But since you are here, could you please change the style to:
static int describe_command(struct output *out, char *command,
const char *path, int verbose)
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-02-09 5:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 16:34 [PATCH] Prototype all function definitions for C23 compat наб
2023-02-09 4:53 ` Herbert Xu [this message]
2023-02-09 13:11 ` [PATCH v2] " наб
2023-02-10 2:43 ` Herbert Xu
2023-02-10 2:51 ` Harald van Dijk
2023-02-10 3:01 ` Herbert Xu
2023-02-10 11:24 ` [PATCH v3] " наб
2024-04-06 9:06 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+R8SCX45HlQY8Xk@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=dash@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.