Re: [PATCH v2 3/4] Makefile: really use and document sha1collisiondetection by default

From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Eric Sunshine" <sunshine@sunshineco.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	git@vger.kernel.org, "Mike Hommey" <mh@glandium.org>,
	"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
	"Glen Choo" <chooglen@google.com>,
	"Eric DeCosta" <edecosta@mathworks.com>
Subject: Re: [PATCH v2 3/4] Makefile: really use and document sha1collisiondetection by default
Date: Thu, 20 Oct 2022 21:15:16 +0000	[thread overview]
Message-ID: <Y1G6ZEQbTBS1zqdL@tapette.crustytoothpaste.net> (raw)
In-Reply-To: <xmqqo7u7srp4.fsf@gitster.g>

[-- Attachment #1: Type: text/plain, Size: 1576 bytes --]

On 2022-10-19 at 16:28:55, Junio C Hamano wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
> 
> >> diff --git a/Makefile b/Makefile
> >> +ifdef DC_SHA1
> >> +$(error the DC_SHA1 flag is no longer used, and has become the default. Adjust your build scripts accordingly)
> >> +endif
> >
> > bikeshedding: Do we really need to penalize (abuse) people merely for
> > asking us to do what we're already doing anyhow?
> 
> A valid question.
> 
> I can understand and very much appreciate [1/4] as a very focused
> fix to the problem.  Very small part of this step, namely, make the
> DC_SHA1 the default everywhere, is also very much welcome.
> 
> Everything else I see in these patches are extra "while we are at
> it" that should not exist.  These "while at it" changes tend to
> somehow implement more subjective choices that will cause more
> discussion and take more review resources.  Not all "white at it"
> may be more subjective, but at least in this series, they appear
> to be.

I will definitely say that we should be using SHA-1-DC by default
everywhere and I'm fine with that change.  I don't think we should fail
if someone sets the former knob, since I don't recall us doing that
elsewhere.  It also seems bad to bother folks if we're already doing
what they asked for (and what we want them to do anyway).

I don't have a strong attachment to the remainder of the series and
agree that maybe a different series would be a better location for those
patches.
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 263 bytes --]