From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Gerald Loacker <gerald.loacker@wolfvision.net>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jakob Hauser <jahau@rocketmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Michael Riesch <michael.riesch@wolfvision.net>
Subject: Re: [PATCH v4 3/3] iio: magnetometer: add ti tmag5273 driver
Date: Wed, 30 Nov 2022 12:55:01 +0200 [thread overview]
Message-ID: <Y4c2hWw6kywpChb3@smile.fi.intel.com> (raw)
In-Reply-To: <b2d8b5a6-15a6-9cca-9f87-fbbe1acfa4f3@wolfvision.net>
On Wed, Nov 30, 2022 at 10:04:41AM +0100, Gerald Loacker wrote:
> Am 29.11.2022 um 17:37 schrieb Andy Shevchenko:
> > On Tue, Nov 29, 2022 at 07:45:40AM +0100, Gerald Loacker wrote:
...
> >> + snprintf(data->name, sizeof(data->name), "tmag5273x%1u", data->version);
> >
> > Thinking more about this format, perhaps
> >
> > snprintf(data->name, sizeof(data->name), "tmag5273x-v%1u", data->version);
> >
> > ?
>
> I'd prefer to keep this as it's related to the orderable part number,
> e.g. TMAG5273A1 / TMAG5273A2.
I see, can you add a comment above to clarify the chosen format?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-11-30 10:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 6:45 [PATCH v4 0/3] add ti tmag5273 driver Gerald Loacker
2022-11-29 6:45 ` [PATCH v4 1/3] iio: add struct declaration for iio types Gerald Loacker
2022-11-29 16:26 ` Andy Shevchenko
2022-11-29 6:45 ` [PATCH v4 2/3] dt-bindings: iio: magnetometer: add ti tmag5273 documentation file Gerald Loacker
2022-11-29 6:45 ` [PATCH v4 3/3] iio: magnetometer: add ti tmag5273 driver Gerald Loacker
2022-11-29 16:37 ` Andy Shevchenko
2022-11-29 16:39 ` Andy Shevchenko
2022-11-30 9:04 ` Gerald Loacker
2022-11-30 10:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4c2hWw6kywpChb3@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=jahau@rocketmail.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.riesch@wolfvision.net \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.