From: Christoph Hellwig <hch@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: luca.boccassi@gmail.com, linux-block@vger.kernel.org,
jonathan.derrick@linux.dev, gmazyland@gmail.com, axboe@kernel.dk,
stepan.horacek@gmail.com
Subject: Re: [PATCH] sed-opal: if key is available from IOC_OPAL_SAVE use it when locking
Date: Fri, 2 Dec 2022 01:11:06 -0800 [thread overview]
Message-ID: <Y4nBKoTQfgr8u5wS@infradead.org> (raw)
In-Reply-To: <20221202084845.66mn2m3srfabehnu@wittgenstein>
On Fri, Dec 02, 2022 at 09:48:45AM +0100, Christian Brauner wrote:
> It might be better to add an ioctl that would allow to set an option on
> the opal device after it was opened which marks it as closable without
> providing the key?
Yes.
And while we're at it: please fix the overly long lines in the block
comment that make it completely unreadable.
next prev parent reply other threads:[~2022-12-02 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 0:36 [PATCH] sed-opal: if key is available from IOC_OPAL_SAVE use it when locking luca.boccassi
2022-12-02 8:48 ` Christian Brauner
2022-12-02 9:11 ` Christoph Hellwig [this message]
2022-12-02 10:28 ` Luca Boccassi
2022-12-02 10:37 ` Christian Brauner
2022-12-03 0:12 ` [PATCH v2] sed-opal: allow using IOC_OPAL_SAVE for locking too luca.boccassi
2022-12-05 7:09 ` Christoph Hellwig
2022-12-06 0:03 ` [PATCH v3] " luca.boccassi
2022-12-06 8:30 ` Christoph Hellwig
2022-12-06 9:23 ` Christian Brauner
2022-12-06 9:29 ` [PATCH v4] " luca.boccassi
2022-12-08 16:18 ` Jens Axboe
2022-12-08 16:19 ` Luca Boccassi
2022-12-08 16:20 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4nBKoTQfgr8u5wS@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=gmazyland@gmail.com \
--cc=jonathan.derrick@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=luca.boccassi@gmail.com \
--cc=stepan.horacek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.