Re: [PATCH 1/2] platform/x86: simatic-ipc: correct name of a model

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	Mark Gross <markgross@kernel.org>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] platform/x86: simatic-ipc: correct name of a model
Date: Tue, 27 Dec 2022 22:18:25 +0200	[thread overview]
Message-ID: <Y6tTEVjnS+RjAi9b@smile.fi.intel.com> (raw)
In-Reply-To: <20221222150443.722e5bf8@md1za8fc.ad001.siemens.net>

On Thu, Dec 22, 2022 at 03:04:43PM +0100, Henning Schild wrote:
> Am Thu, 22 Dec 2022 14:44:18 +0200
> schrieb Andy Shevchenko <andriy.shevchenko@linux.intel.com>:
> > On Thu, Dec 22, 2022 at 11:37:19AM +0100, Henning Schild wrote:
> > > What we called IPC427G should be renamed to BX-39A to be more in
> > > line with the actual product name.  
> > 
> > Can you tell what does the current name mean?
> 
> 427G is an internal prototype name using the naming scheme that these
> kind of machines used to use for several generations. For some reason
> the naming scheme was changed and the public product name is BX-39A.
> 
> Please do not ask me why. But if you would happen to own such a device
> you would know it as BX-39A _only_.
> 
> > Depending on that I would consider either your approach here or
> > perhaps just adding a comment in each of the places.
> 
> Mentioning the name 427G, even as a comment, does not make much sense.
> Since the box is for sale it is called BX-39A and was never called 427G.
> 
> I used the internal prototype name and only recently learned that never
> became the final name. And this cleanup makes sure nobody gets
> confused.

Thanks for clarifications!

-- 
With Best Regards,
Andy Shevchenko