All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@linux.kernel.org
Subject: Inquiry around 'b4 send' individual patch Cc's
Date: Wed, 28 Dec 2022 17:24:37 -0700	[thread overview]
Message-ID: <Y6zeRaKlqNhh72OD@dev-arch.thelio-3990X> (raw)

Hi Konstantin,

I have started using 'b4 prep' for a larger series I am getting ready to
send, thank you for such a great tool, as it makes wrangling and sending
larger series a lot simplier, especially having the cover letter as a
part of the history.

I have traditionally used '--to' and '--cc' flags to 'git send-email' to
send series to people who need to see the whole thing in combination
with Cc trailers in the cover letter and patches for people who only
need to acknowledge certain patches but need the full context of the
series.

Based on your announcement here [1], it appears that in b4, I would just
need to add trailers to the cover letter for people who should get the
whole series and trailers in individual patches for people who should
get just those patches and the cover letter.

This appears to work for me but I noticed that if there are multiple
patches that need to be Cc'd to the same people in the series, they are
not deduplicated for the cover letter. For example, I see the following
output with 'b4 prep -d' for this series, which has two MIPS patches,
three PowerPC patches, and three s390 patches, which all include the
exact same trailers generated from scripts/get_maintainer.pl:

    | To: Masahiro Yamada <masahiroy@kernel.org>, Nick Desaulniers <ndesaulniers@google.com>
    | Cc: Nicolas Schier <nicolas@fjasle.eu>, Tom Rix <trix@redhat.com>, linux-kbuild@vger.kernel.org,
    |  llvm@lists.linux.dev, Nathan Chancellor <nathan@kernel.org>, kernel test robot <lkp@intel.com>,
    |  Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
    |  Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org, Arvind Sankar <nivedita@alum.mit.edu>,
    |  Thomas Bogendoerfer <tsbogend@alpha.franken.de>, linux-mips@vger.kernel.org,
    |  Thomas Bogendoerfer <tsbogend@alpha.franken.de>, linux-mips@vger.kernel.org,
    |  Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,
    |  Christophe Leroy <christophe.leroy@csgroup.eu>, linuxppc-dev@lists.ozlabs.org,
    |  Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,
    |  Christophe Leroy <christophe.leroy@csgroup.eu>, linuxppc-dev@lists.ozlabs.org,
    |  Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,
    |  Christophe Leroy <christophe.leroy@csgroup.eu>, linuxppc-dev@lists.ozlabs.org,
    |  Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,
    |  Alexander Gordeev <agordeev@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>,
    |  Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
    |  Vasily Gorbik <gor@linux.ibm.com>, Alexander Gordeev <agordeev@linux.ibm.com>,
    |  Christian Borntraeger <borntraeger@linux.ibm.com>, Sven Schnelle <svens@linux.ibm.com>,
    |  linux-s390@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>, Vasily Gorbik <gor@linux.ibm.com>,
    |  Alexander Gordeev <agordeev@linux.ibm.com>, Christian Borntraeger <borntraeger@linux.ibm.com>,
    |  Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org, Harry Wentland <harry.wentland@amd.com>,
    |  Leo Li <sunpeng.li@amd.com>, Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
    |  Alex Deucher <alexander.deucher@amd.com>, Christian König <christian.koenig@amd.com>,
    |  "Pan, Xinhui" <Xinhui.Pan@amd.com>, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org

Do note, I include in the commit message something like:

    Signed-off-by: Nathan Chancellor <nathan@kernel.org>
    ---
    Cc: ...
    Cc: ...

so that they are not added to the patch contents when they are applied.

Additionally, when I reflect this series back to myself, I noticed that
something appears to get messed up with the linuxppc-dev CC, as it gets
combined with Michael's name; I see the following in mutt for the same
series:

    To: Masahiro Yamada <masahiroy@kernel.org>,
            Nick Desaulniers <ndesaulniers@google.com>
    Cc: Nicolas Schier <nicolas@fjasle.eu>, Tom Rix <trix@redhat.com>,
            linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
            Nathan Chancellor <nathan@kernel.org>,
            kernel test robot <lkp@intel.com>,
            Thomas Gleixner <tglx@linutronix.de>,
            Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
            Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
            Arvind Sankar <nivedita@alum.mit.edu>,
            Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
            linux-mips@vger.kernel.org,
            Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
            linux-mips@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
            Nicholas Piggin <npiggin@gmail.com>,
            Christophe Leroy <christophe.leroy@csgroup.eu>,
            "linuxppc-dev@lists.ozlabs.org , Michael Ellerman" <mpe@ellerman.id.au>,
            Nicholas Piggin <npiggin@gmail.com>,
            Christophe Leroy <christophe.leroy@csgroup.eu>,
            "linuxppc-dev@lists.ozlabs.org , Michael Ellerman" <mpe@ellerman.id.au>,
            Nicholas Piggin <npiggin@gmail.com>,
            Christophe Leroy <christophe.leroy@csgroup.eu>,
            "linuxppc-dev@lists.ozlabs.org , Heiko Carstens" <hca@linux.ibm.com>,
            Vasily Gorbik <gor@linux.ibm.com>,
            Alexander Gordeev <agordeev@linux.ibm.com>,
            ", Christian Borntraeger" <borntraeger@linux.ibm.com>,
            Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org,
            Heiko Carstens <hca@linux.ibm.com>,
            Vasily Gorbik <gor@linux.ibm.com>,
            Alexander Gordeev <agordeev@linux.ibm.com>,
            Christian Borntraeger <borntraeger@linux.ibm.com>,
            Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org,
            Heiko Carstens <hca@linux.ibm.com>,
            Vasily Gorbik <gor@linux.ibm.com>,
            Alexander Gordeev <agordeev@linux.ibm.com>,
            Christian Borntraeger <borntraeger@linux.ibm.com>,
            Sven Schnelle <svens@linux.ibm.com>, linux-s390@vger.kernel.org,
            Harry Wentland <harry.wentland@amd.com>,
            Leo Li <sunpeng.li@amd.com>,
            Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
            Alex Deucher <alexander.deucher@amd.com>,
            Christian König <christian.koenig@amd.com>,
            "Pan, Xinhui" <Xinhui.Pan@amd.com>, amd-gfx@lists.freedesktop.org,
            dri-devel@lists.freedesktop.org

If I am doing something wrong, please feel free to let me know! If there
is anything I can provide or test if this is a real problem, I am more
than happy to do so.

[1]: https://lore.kernel.org/20221202155644.kbnqvune7mo4khue@meerkat.local/

Cheers,
Nathan

             reply	other threads:[~2022-12-29  0:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29  0:24 Nathan Chancellor [this message]
2023-01-03 22:40 ` Inquiry around 'b4 send' individual patch Cc's Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6zeRaKlqNhh72OD@dev-arch.thelio-3990X \
    --to=nathan@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.