Re: [PATCH v2] i386: Deprecate the -no-hpet QEMU command line option

From: Peter Krempa <pkrempa@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, libvir-list@redhat.com,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] i386: Deprecate the -no-hpet QEMU command line option
Date: Tue, 3 Jan 2023 09:57:09 +0100	[thread overview]
Message-ID: <Y7Pt5YtozCrzVEQ2@angien.pipo.sk> (raw)
In-Reply-To: <20221229114913.260400-1-thuth@redhat.com>

On Thu, Dec 29, 2022 at 12:49:13 +0100, Thomas Huth wrote:
> The HPET setting has been turned into a machine property a while ago
> already, so we should finally do the next step and deprecate the
> legacy CLI option, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  v2:
>  - Rebased to current version from master branch / adjusted version info
>  - Dropped the descrpition in hw/i386/pc.c (already done via another patch)
> 
>  Note: The "hpet" property should now show up in the output of the
>  "query-command-line-options" QMP command since commit 2f129fc107b4a, so
>  it should be feasible for libvirt now to properly probe for the property .
> 
>  docs/about/deprecated.rst | 6 ++++++
>  softmmu/vl.c              | 1 +
>  qemu-options.hx           | 2 +-
>  3 files changed, 8 insertions(+), 1 deletion(-)

Libvirt currently still uses '-no-hpet' but adapting to configure it via
machine should be straightforward. I'll post the patches soon hopefully.