From: Matthew Wilcox <willy@infradead.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, songmuchun@bytedance.com,
tsahu@linux.ibm.com, jhubbard@nvidia.com
Subject: Re: [PATCH mm-unstable 8/8] mm/hugetlb: convert demote_free_huge_page to folios
Date: Sat, 7 Jan 2023 01:31:00 +0000 [thread overview]
Message-ID: <Y7jLVJ9kvBFCUhNd@casper.infradead.org> (raw)
In-Reply-To: <Y7jGyH9Atv3sPjcZ@monkey>
On Fri, Jan 06, 2023 at 05:11:36PM -0800, Mike Kravetz wrote:
> On 01/03/23 13:13, Sidhartha Kumar wrote:
> > @@ -3477,15 +3477,15 @@ static int demote_free_huge_page(struct hstate *h, struct page *page)
> > mutex_lock(&target_hstate->resize_lock);
> > for (i = 0; i < pages_per_huge_page(h);
> > i += pages_per_huge_page(target_hstate)) {
> > - subpage = nth_page(page, i);
> > - folio = page_folio(subpage);
> > + subpage = folio_page(folio, i);
> > + subfolio = page_folio(subpage);
>
> No problems with the code, but I am not in love with the name subfolio.
> I know it is patterned after 'subpage'. For better or worse, the term
> subpage is used throughout the kernel. This would be the first usage of
> the term 'subfolio'.
>
> Matthew do you have any comments on the naming? It is local to hugetlb,
> but I would hate to see use of the term subfolio based on its introduction
> here.
I'm really not a fan of it either. I intended to dive into this patch
and understand the function it's modifying, in the hopes of suggesting
a better name and/or method.
Since I haven't done that yet, maybe "new" or "dest" names work?
next prev parent reply other threads:[~2023-01-07 1:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-03 19:13 [PATCH mm-unstable 0/9] continue hugetlb folio conversions Sidhartha Kumar
2023-01-03 19:13 ` [PATCH mm-unstable 1/8] mm/hugetlb: convert isolate_hugetlb to folios Sidhartha Kumar
2023-01-03 20:56 ` Matthew Wilcox
2023-01-06 23:04 ` Mike Kravetz
2023-01-03 19:13 ` [PATCH mm-unstable 2/8] mm/hugetlb: convert __update_and_free_page() " Sidhartha Kumar
2023-01-06 23:46 ` Mike Kravetz
2023-01-03 19:13 ` [PATCH mm-unstable 3/8] mm/hugetlb: convert dequeue_hugetlb_page_node functions " Sidhartha Kumar
2023-01-03 21:00 ` Matthew Wilcox
2023-01-06 23:57 ` Mike Kravetz
2023-01-03 19:13 ` [PATCH mm-unstable 4/8] mm/hugetlb: convert alloc_surplus_huge_page() " Sidhartha Kumar
2023-01-07 0:15 ` Mike Kravetz
2023-01-03 19:13 ` [PATCH mm-unstable 5/8] mm/hugetlb: increase use of folios in alloc_huge_page() Sidhartha Kumar
2023-01-07 0:30 ` Mike Kravetz
2023-01-03 19:13 ` [PATCH mm-unstable 6/8] mm/hugetlb: convert alloc_migrate_huge_page to folios Sidhartha Kumar
2023-01-07 0:54 ` Mike Kravetz
2023-01-09 16:26 ` Sidhartha Kumar
2023-01-09 18:21 ` Mike Kravetz
2023-01-03 19:13 ` [PATCH mm-unstable 7/8] mm/hugetlb: convert restore_reserve_on_error() " Sidhartha Kumar
2023-01-07 0:57 ` Mike Kravetz
2023-01-03 19:13 ` [PATCH mm-unstable 8/8] mm/hugetlb: convert demote_free_huge_page " Sidhartha Kumar
2023-01-07 1:11 ` Mike Kravetz
2023-01-07 1:31 ` Matthew Wilcox [this message]
2023-01-07 20:55 ` Mike Kravetz
2023-01-09 16:36 ` Sidhartha Kumar
2023-01-09 18:23 ` Mike Kravetz
2023-01-09 20:01 ` John Hubbard
2023-01-09 20:53 ` Sidhartha Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7jLVJ9kvBFCUhNd@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=sidhartha.kumar@oracle.com \
--cc=songmuchun@bytedance.com \
--cc=tsahu@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.