From: Jason Gunthorpe <jgg@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Dragos Tatulea <dtatulea@nvidia.com>,
linux-rdma@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH rdma-rc v1] IB/IPoIB: Fix legacy IPoIB due to wrong number of queues
Date: Mon, 23 Jan 2023 14:32:05 -0400 [thread overview]
Message-ID: <Y87SpbbdYE3A+y46@nvidia.com> (raw)
In-Reply-To: <Y80vs3KQ1QfB+KBf@unreal>
On Sun, Jan 22, 2023 at 02:44:35PM +0200, Leon Romanovsky wrote:
> > And the return of a really big number from ops->get_num_rx_queues is
> > pretty ugly too, ideally that would be fixed to pass in some function
> > arguments and obtain the ppriv so it can return the actual maximum
> > number of queues and we don't waste a bunch of memory..
>
> .get_num_rx_queues() is declared as void, so it can't have any complex
> logic except returns some global define.
Well, yes, you'd have to add some arguments..
Jason
next prev parent reply other threads:[~2023-01-23 18:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 17:02 [PATCH rdma-rc v1] IB/IPoIB: Fix legacy IPoIB due to wrong number of queues Leon Romanovsky
2023-01-20 20:52 ` Jason Gunthorpe
2023-01-21 8:40 ` Dragos Tatulea
2023-01-22 12:44 ` Leon Romanovsky
2023-01-23 18:32 ` Jason Gunthorpe [this message]
2023-01-24 6:27 ` Leon Romanovsky
2023-01-24 13:00 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y87SpbbdYE3A+y46@nvidia.com \
--to=jgg@nvidia.com \
--cc=dtatulea@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.