From: Petr Mladek <pmladek@suse.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Zhen Lei <thunder.leizhen@huawei.com>,
bpf@vger.kernel.org, live-patching@vger.kernel.org,
linux-modules@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCHv3 bpf-next 3/3] bpf: Change modules resolving for kprobe multi link
Date: Wed, 18 Jan 2023 15:10:32 +0100 [thread overview]
Message-ID: <Y8f92N1AjLM0hYis@alley> (raw)
In-Reply-To: <20230116101009.23694-4-jolsa@kernel.org>
On Mon 2023-01-16 11:10:09, Jiri Olsa wrote:
> We currently use module_kallsyms_on_each_symbol that iterates all
> modules/symbols and we try to lookup each such address in user
> provided symbols/addresses to get list of used modules.
>
> This fix instead only iterates provided kprobe addresses and calls
> __module_address on each to get list of used modules. This turned
> out ot be simpler and also bit faster.
>
> On my setup with workload (executed 10 times):
>
> # test_progs -t kprobe_multi_bench_attach/modules
>
> Current code:
>
> Performance counter stats for './test.sh' (5 runs):
>
> 76,081,161,596 cycles:k ( +- 0.47% )
>
> 18.3867 +- 0.0992 seconds time elapsed ( +- 0.54% )
>
> With the fix:
>
> Performance counter stats for './test.sh' (5 runs):
>
> 74,079,889,063 cycles:k ( +- 0.04% )
>
> 17.8514 +- 0.0218 seconds time elapsed ( +- 0.12% )
>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
The change looks good to me:
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
next prev parent reply other threads:[~2023-01-18 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 10:10 [PATCHv3 bpf-next 0/3] kallsyms: Optimize the search for module symbols by livepatch and bpf Jiri Olsa
2023-01-16 10:10 ` [PATCHv3 bpf-next 1/3] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Jiri Olsa
2023-01-17 14:47 ` Miroslav Benes
2023-01-17 15:25 ` Luis Chamberlain
2023-01-17 15:26 ` Luis Chamberlain
2023-01-18 0:17 ` Luis Chamberlain
2023-01-16 10:10 ` [PATCHv3 bpf-next 2/3] selftests/bpf: Add serial_test_kprobe_multi_bench_attach_kernel/module tests Jiri Olsa
2023-01-16 10:10 ` [PATCHv3 bpf-next 3/3] bpf: Change modules resolving for kprobe multi link Jiri Olsa
2023-01-18 2:16 ` Leizhen (ThunderTown)
2023-01-18 14:10 ` Petr Mladek [this message]
2023-01-20 1:30 ` [PATCHv3 bpf-next 0/3] kallsyms: Optimize the search for module symbols by livepatch and bpf patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8f92N1AjLM0hYis@alley \
--to=pmladek@suse.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sdf@google.com \
--cc=songliubraving@fb.com \
--cc=thunder.leizhen@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.