From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Marek Vasut <marex@denx.de>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-serial@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Johan Hovold <johan@kernel.org>
Subject: Re: [tty:tty-linus 4/7] drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared
Date: Fri, 20 Jan 2023 07:46:27 +0100 [thread overview]
Message-ID: <Y8o4w8jRJAUSPIDx@kroah.com> (raw)
In-Reply-To: <f5f4b504-8e58-2844-fa26-c8896a625794@denx.de>
On Thu, Jan 19, 2023 at 07:08:00PM +0100, Marek Vasut wrote:
> On 1/19/23 18:33, kernel test robot wrote:
>
> [...]
>
> > cc58d0a3f0a475 Erwan Le Ray 2021-10-20 800 /* Receiver timeout irq for DMA RX */
> > f24771b62a8323 Marek Vasut 2023-01-12 801 if (stm32_usart_rx_dma_enabled(port) && !stm32_port->throttled) {
> > f24771b62a8323 Marek Vasut 2023-01-12 802 spin_lock(&port->lock);
> > 6333a485062172 Erwan Le Ray 2021-10-25 803 size = stm32_usart_receive_chars(port, false);
> > 6333a485062172 Erwan Le Ray 2021-10-25 @804 uart_unlock_and_check_sysrq_irqrestore(port, flags);
>
> +CC Johan
>
> This one should be uart_unlock_and_check_sysrq(port); I think . If that's
> correct, then I'll send a patch.
>
> > 6333a485062172 Erwan Le Ray 2021-10-25 805 if (size)
> > 6333a485062172 Erwan Le Ray 2021-10-25 806 tty_flip_buffer_push(tport);
> > 6333a485062172 Erwan Le Ray 2021-10-25 807 }
>
> [...]
Let me go revert this now until you all get it fixed up in a new change,
I can't have a broken branch right now, sorry.
greg k-h
next prev parent reply other threads:[~2023-01-20 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 17:33 [tty:tty-linus 4/7] drivers/tty/serial/stm32-usart.c:804:62: error: 'flags' undeclared kernel test robot
2023-01-19 18:08 ` Marek Vasut
2023-01-20 6:46 ` Greg Kroah-Hartman [this message]
2023-01-20 7:56 ` Johan Hovold
2023-01-20 16:04 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8o4w8jRJAUSPIDx@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bigeasy@linutronix.de \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=marex@denx.de \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.