From: Nicolin Chen <nicolinc@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "jgg@nvidia.com" <jgg@nvidia.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"Liu, Yi L" <yi.l.liu@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v1 2/8] iommu: Introduce a new iommu_group_replace_domain() API
Date: Fri, 3 Feb 2023 09:45:14 -0800 [thread overview]
Message-ID: <Y91IKoDq2xrWp1Jq@Asurada-Nvidia> (raw)
In-Reply-To: <BN9PR11MB5276BB497D32073A1F4CBE238CD79@BN9PR11MB5276.namprd11.prod.outlook.com>
On Fri, Feb 03, 2023 at 08:26:44AM +0000, Tian, Kevin wrote:
> > +/**
> > + * iommu_group_replace_domain - replace the domain that a group is
> > attached to
> > + * @new_domain: new IOMMU domain to replace with
> > + * @group: IOMMU group that will be attached to the new domain
> > + *
> > + * This API allows the group to switch domains without being forced to go to
> > + * the blocking domain in-between.
> > + *
> > + * If the attached domain is a core domain (e.g. a default_domain), it will act
> > + * just like the iommu_attach_group().
>
> I think you meant "the currently-attached domain", which implies a
> 'detached' state as you replied to Baolu.
Hmm, I don't see an implication, since we only have either
"the attached domain" or "a new domain" in the context?
With that being said, I can add "currently" in v2:
* If the currently attached domain is a core domain (e.g. a default_domain),
* it will act just like the iommu_attach_group().
Thanks
Nic
next prev parent reply other threads:[~2023-02-03 17:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 7:05 [PATCH v1 0/8] Add IO page table replacement support Nicolin Chen
2023-02-02 7:05 ` [PATCH v1 1/8] iommu: Move dev_iommu_ops() to private header Nicolin Chen
2023-02-02 7:05 ` [PATCH v1 2/8] iommu: Introduce a new iommu_group_replace_domain() API Nicolin Chen
2023-02-02 10:21 ` Baolu Lu
2023-02-02 19:14 ` Nicolin Chen
2023-02-03 1:33 ` Baolu Lu
2023-02-03 1:41 ` Nicolin Chen
2023-02-03 2:35 ` Baolu Lu
2023-02-03 8:26 ` Tian, Kevin
2023-02-03 15:03 ` Jason Gunthorpe
2023-02-03 17:53 ` Nicolin Chen
2023-02-06 6:57 ` Tian, Kevin
2023-02-06 13:25 ` Jason Gunthorpe
2023-02-07 0:32 ` Tian, Kevin
2023-02-07 12:22 ` Jason Gunthorpe
2023-02-08 4:25 ` Tian, Kevin
2023-02-08 12:42 ` Jason Gunthorpe
2023-02-07 19:16 ` Nicolin Chen
2023-02-03 17:45 ` Nicolin Chen [this message]
2023-02-06 6:40 ` Tian, Kevin
2023-02-02 7:05 ` [PATCH v1 3/8] iommufd: Create access in vfio_iommufd_emulated_bind() Nicolin Chen
2023-02-03 9:23 ` Tian, Kevin
2023-02-03 9:28 ` Tian, Kevin
2023-02-02 7:05 ` [PATCH v1 4/8] iommufd/selftest: Add IOMMU_TEST_OP_ACCESS_SET_IOAS coverage Nicolin Chen
2023-02-02 7:05 ` [PATCH v1 5/8] iommufd: Add replace support in iommufd_access_set_ioas() Nicolin Chen
2023-02-03 10:10 ` Tian, Kevin
2023-02-03 12:31 ` Jason Gunthorpe
2023-02-03 22:25 ` Nicolin Chen
2023-02-02 7:05 ` [PATCH v1 6/8] iommufd/selftest: Add coverage for access->ioas replacement Nicolin Chen
2023-02-02 7:05 ` [PATCH v1 7/8] iommufd/device: Use iommu_group_replace_domain() Nicolin Chen
2023-02-06 8:46 ` Tian, Kevin
2023-02-06 19:17 ` Nicolin Chen
2023-02-07 0:37 ` Tian, Kevin
2023-02-02 7:05 ` [PATCH v1 8/8] vfio-iommufd: Support IO page table replacement Nicolin Chen
2023-02-06 8:49 ` Tian, Kevin
2023-02-06 18:54 ` Nicolin Chen
2023-02-03 8:09 ` [PATCH v1 0/8] Add IO page table replacement support Tian, Kevin
2023-02-03 15:04 ` Jason Gunthorpe
2023-02-06 6:39 ` Tian, Kevin
2023-02-06 13:26 ` Jason Gunthorpe
2023-02-07 0:34 ` Tian, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y91IKoDq2xrWp1Jq@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.