From: Christoph Hellwig <hch@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@infradead.org>,
Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
David Hildenbrand <david@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v9 8/8] block: convert bio_map_user_iov to use iov_iter_extract_pages
Date: Tue, 24 Jan 2023 11:03:46 -0800 [thread overview]
Message-ID: <Y9Arko99HMrGl6nC@infradead.org> (raw)
In-Reply-To: <20230124170108.1070389-9-dhowells@redhat.com>
On Tue, Jan 24, 2023 at 05:01:08PM +0000, David Howells wrote:
> This will pin pages or leave them unaltered rather than getting a ref on
> them as appropriate to the iterator.
>
> The pages need to be pinned for DIO rather than having refs taken on them
> to prevent VM copy-on-write from malfunctioning during a concurrent fork()
> (the result of the I/O could otherwise end up being visible to/affected by
> the child process).
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-01-24 19:04 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 17:01 [PATCH v9 0/8] iov_iter: Improve page extraction (pin or just list) David Howells
2023-01-24 17:01 ` [PATCH v9 1/8] iov_iter: Define flags to qualify page extraction David Howells
2023-01-24 19:00 ` Christoph Hellwig
2023-01-24 19:23 ` John Hubbard
2023-01-24 17:01 ` [PATCH v9 2/8] iov_iter: Add a function to extract a page list from an iterator David Howells
2023-01-24 19:00 ` Christoph Hellwig
2023-01-24 20:50 ` John Hubbard
2023-01-24 21:10 ` David Howells
2023-01-24 17:01 ` [PATCH v9 3/8] iomap: Don't get an reference on ZERO_PAGE for direct I/O block zeroing David Howells
2023-01-24 19:01 ` Christoph Hellwig
2023-01-24 19:25 ` John Hubbard
2023-01-24 20:41 ` David Howells
2023-01-25 6:28 ` Christoph Hellwig
2023-01-24 17:01 ` [PATCH v9 4/8] block: Fix bio_flagged() so that gcc can better optimise it David Howells
2023-01-24 19:28 ` John Hubbard
2023-01-24 20:55 ` David Howells
2023-01-24 17:01 ` [PATCH v9 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic David Howells
2023-01-24 19:01 ` Christoph Hellwig
2023-01-24 19:47 ` John Hubbard
2023-01-24 21:17 ` David Howells
2023-01-25 6:30 ` Christoph Hellwig
2023-01-24 17:01 ` [PATCH v9 6/8] block: Switch to pinning pages David Howells
2023-01-24 19:02 ` Christoph Hellwig
2023-01-24 19:50 ` John Hubbard
2023-01-24 20:59 ` David Howells
2023-01-25 6:30 ` Christoph Hellwig
2023-01-24 17:01 ` [PATCH v9 7/8] block: Convert bio_iov_iter_get_pages to use iov_iter_extract_pages David Howells
2023-01-24 19:03 ` Christoph Hellwig
2023-01-24 20:00 ` John Hubbard
2023-01-24 20:46 ` David Howells
2023-01-24 17:01 ` [PATCH v9 8/8] block: convert bio_map_user_iov " David Howells
2023-01-24 19:03 ` Christoph Hellwig [this message]
2023-01-24 20:08 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9Arko99HMrGl6nC@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.