All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-acpi@vger.kernel.org, linux-media@vger.kernel.org,
	rafael@kernel.org, heikki.krogerus@linux.intel.com
Subject: Re: [PATCH v3 2/8] ACPI: property: Parse _CRS CSI-2 descriptor
Date: Mon, 30 Jan 2023 23:37:53 +0200	[thread overview]
Message-ID: <Y9g4sSdDgplq1niN@smile.fi.intel.com> (raw)
In-Reply-To: <Y9g0JvBWvn9Rsi7Q@kekkonen.localdomain>

On Mon, Jan 30, 2023 at 11:18:30PM +0200, Sakari Ailus wrote:
> On Fri, Jan 27, 2023 at 12:08:39PM +0200, Andy Shevchenko wrote:
> > On Thu, Jan 26, 2023 at 12:40:55AM +0200, Sakari Ailus wrote:

...

> > > +	/* Collect the devices that have a _CRS CSI-2 resource */
> > > +	acpi_walk_namespace(ACPI_TYPE_DEVICE, handle, ACPI_UINT32_MAX,
> > 
> > Other serial buses limit the DEPTH by 32, why do we need more here?
> 
> I'm using the same value as for scanning devices to be added. Effectively
> this is not a practical limit but it doesn't need to be.

Hmm... Theoretically one may supply a malformed table, quite compact, but with
huge amount of "fake" devices. I would limit this the same way. If we got a
report of the depth not being enough we may bump based on the reality. This also
may limit scanning time.

> > > +			    scan_check_crs_csi2, NULL, &crs_csi2_handles, NULL);

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2023-01-30 21:38 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25 22:40 [PATCH v3 0/8] ACPI _CRS CSI-2 and MIPI DisCo for Imaging support Sakari Ailus
2023-01-25 22:40 ` [PATCH v3 1/8] ACPI: property: Parse data node string references in properties Sakari Ailus
2023-01-27  9:57   ` Andy Shevchenko
2023-01-30 18:21   ` Rafael J. Wysocki
2023-01-30 21:34     ` Andy Shevchenko
2023-01-25 22:40 ` [PATCH v3 2/8] ACPI: property: Parse _CRS CSI-2 descriptor Sakari Ailus
2023-01-27 10:08   ` Andy Shevchenko
2023-01-30 21:18     ` Sakari Ailus
2023-01-30 21:37       ` Andy Shevchenko [this message]
2023-01-30 21:45         ` Sakari Ailus
2023-02-02 19:57   ` Rafael J. Wysocki
2023-02-02 20:57     ` Sakari Ailus
2023-01-25 22:40 ` [PATCH v3 3/8] device property: Add SOFTWARE_NODE() macro for defining software nodes Sakari Ailus
2023-01-25 22:40 ` [PATCH v3 4/8] ACPI: property: Generate camera swnodes for ACPI and DisCo for Imaging Sakari Ailus
2023-01-27 10:35   ` Andy Shevchenko
2023-01-27 10:35     ` Andy Shevchenko
2023-01-30 21:22     ` Sakari Ailus
2023-01-30 21:39       ` Andy Shevchenko
2023-01-30 21:46         ` Sakari Ailus
2023-01-25 22:40 ` [PATCH v3 5/8] ACPI: property: Dig "rotation" property for devices with CSI2 _CRS Sakari Ailus
2023-01-25 22:40 ` [PATCH v3 6/8] ACPI: property: Rename parsed MIPI DisCo for Imaging properties Sakari Ailus
2023-01-25 22:41 ` [PATCH v3 7/8] ACPI: property: Skip MIPI property table without "mipi-img" prefix Sakari Ailus
2023-01-25 22:41 ` [PATCH v3 8/8] ACPI: property: Document _CRS CSI-2 and DisCo for Imaging support Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9g4sSdDgplq1niN@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.