Re: [PATCH RESEND 0/5] Fix UPI uncore issue on SPR

From: Steve Wahl <steve.wahl@hpe.com>
To: kan.liang@linux.intel.com
Cc: peterz@infradead.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org, steve.wahl@hpe.com,
	alexander.antonov@linux.intel.com, ak@linux.intel.com,
	eranian@google.com, namhyung@kernel.org
Subject: Re: [PATCH RESEND 0/5] Fix UPI uncore issue on SPR
Date: Tue, 31 Jan 2023 11:17:15 -0600	[thread overview]
Message-ID: <Y9lNG+JnSFNFFAHQ@swahl-home.5wahls.com> (raw)
In-Reply-To: <20230112200105.733466-1-kan.liang@linux.intel.com>

I reviewed this patch series, applied it to a kernel tree, and tested
it on two larger (12+ socket) systems, did not notice any adverse
affects.  So I believe it's appropriate to add both of these tags:

Tested-by: Steve Wahl <steve.wahl@hpe.com>
Reviewed-by: Steve Wahl <steve.wahl@hpe.com>

--> Steve

On Thu, Jan 12, 2023 at 12:01:00PM -0800, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
> 
> The discovery table of UPI on SPR MCC is broken. The patch series is
> to mitigate the issue by providing a hardcode pre-defined table.
> 
> The broken discovery table can trigger a kernel warning message, which
> is overkilled. The patch series also refine the error handling code.
> 
> Kan Liang (5):
>   perf/x86/uncore: Factor out uncore_device_to_die()
>   perf/x86/uncore: Fix potential NULL pointer in uncore_get_alias_name
>   perf/x86/uncore: Ignore broken units in discovery table
>   perf/x86/uncore: Add a quirk for UPI on SPR
>   perf/x86/uncore: Don't WARN_ON_ONCE() for a broken discovery table
> 
>  arch/x86/events/intel/uncore.c           |  34 ++++-
>  arch/x86/events/intel/uncore.h           |   4 +
>  arch/x86/events/intel/uncore_discovery.c |  60 ++++++---
>  arch/x86/events/intel/uncore_discovery.h |  14 +-
>  arch/x86/events/intel/uncore_snbep.c     | 158 ++++++++++++++++++-----
>  5 files changed, 210 insertions(+), 60 deletions(-)
> 
> -- 
> 2.35.1
> 

-- 
Steve Wahl, Hewlett Packard Enterprise