All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan@gerhold.net>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org, bgoswami@codeaurora.org,
	srivasam@codeaurora.org, lgirdwood@gmail.com, broonie@kernel.org,
	Jun Nie <jun.nie@linaro.org>
Subject: Re: [PATCH v2 2/2] ASoC: qcom: Fix broken support to MI2S TERTIARY and QUATERNARY
Date: Tue, 19 Jan 2021 19:44:49 +0100	[thread overview]
Message-ID: <YAcooWUYZkE/Kg8O@gerhold.net> (raw)
In-Reply-To: <20210119171527.32145-3-srinivas.kandagatla@linaro.org>

On Tue, Jan 19, 2021 at 05:15:27PM +0000, Srinivas Kandagatla wrote:
> lpass hdmi support patch totally removed support for MI2S TERTIARY
> and QUATERNARY.
> 
> One of the major issue was spotted with the design of having
> separate SoC specific header files for the common lpass driver.
> This design is prone to break as an when new SoC header is added
> as the common DAI ids of other SoCs will be overwritten by the
> new ones.
> 
> Having a common header qcom,lpass.h should fix the issue and any new
> DAI ids should be added to the common header.
> 
> With this change lpass also needs a new of_xlate function to resolve
> dai name.
> 
> Fixes: 7cb37b7bd0d3 ("ASoC: qcom: Add support for lpass hdmi driver")
> Reported-by: Jun Nie <jun.nie@linaro.org>
> Reported-by: Stephan Gerhold <stephan@gerhold.net>
> Tested-by: Srinivasa Rao <srivasam@codeaurora.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

This applies fine now and HDMI audio works again on DB410c:

Tested-by: Stephan Gerhold <stephan@gerhold.net>

Thank you!
Stephan

  reply	other threads:[~2021-01-19 18:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19 17:15 [PATCH v2 0/2] ASoC: qcom: Fix broken lpass driver Srinivas Kandagatla
2021-01-19 17:15 ` [PATCH v2 1/2] ASoC: dt-bindings: lpass: Fix and common up lpass dai ids Srinivas Kandagatla
2021-01-19 17:15 ` [PATCH v2 2/2] ASoC: qcom: Fix broken support to MI2S TERTIARY and QUATERNARY Srinivas Kandagatla
2021-01-19 18:44   ` Stephan Gerhold [this message]
2021-01-21  0:05 ` [PATCH v2 0/2] ASoC: qcom: Fix broken lpass driver Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YAcooWUYZkE/Kg8O@gerhold.net \
    --to=stephan@gerhold.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@codeaurora.org \
    --cc=broonie@kernel.org \
    --cc=jun.nie@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=srivasam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.