Re: [PATCHv2 bpf-next 0/4] kbuild/resolve_btfids: Invoke resolve_btfids clean in root Makefile

From: Jiri Olsa <jolsa@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andriin@fb.com>,
	Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
	Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCHv2 bpf-next 0/4] kbuild/resolve_btfids: Invoke resolve_btfids clean in root Makefile
Date: Fri, 5 Feb 2021 23:32:53 +0100	[thread overview]
Message-ID: <YB3HlQRKBWKqlYZG@krava> (raw)
In-Reply-To: <CAEf4Bzao-9wNdHxGu1mMhSie78FyWno-RYJM6_Jay8s=hyUWJg@mail.gmail.com>

On Fri, Feb 05, 2021 at 02:27:08PM -0800, Andrii Nakryiko wrote:
> On Fri, Feb 5, 2021 at 4:45 AM Jiri Olsa <jolsa@kernel.org> wrote:
> >
> > hi,
> > resolve_btfids tool is used during the kernel build,
> > so we should clean it on kernel's make clean.
> >
> > v2 changes:
> >   - add Song's acks on patches 1 and 4 (others changed) [Song]
> >   - add missing / [Andrii]
> >   - change srctree variable initialization [Andrii]
> >   - shifted ifdef for clean target [Andrii]
> >
> > thanks,
> > jirka
> >
> >
> 
> FYI, your patch #2 didn't make it into the mailing list (see [0]). So
> maybe wait for a bit and if it doesn't arrive, re-submit?
> 
>   [0] https://patchwork.kernel.org/user/todo/netdevbpf/?series=428711&delegate=121173&state=*

hum and lore shows just 1 and 4
  https://lore.kernel.org/bpf/20210205124020.683286-1-jolsa@kernel.org/

I'll check and resent later 

thanks,
jirka

> 
> > ---
> > Jiri Olsa (4):
> >       tools/resolve_btfids: Build libbpf and libsubcmd in separate directories
> >       tools/resolve_btfids: Check objects before removing
> >       tools/resolve_btfids: Set srctree variable unconditionally
> >       kbuild: Add resolve_btfids clean to root clean target
> >
> >  Makefile                            |  7 ++++++-
> >  tools/bpf/resolve_btfids/.gitignore |  2 --
> >  tools/bpf/resolve_btfids/Makefile   | 44 ++++++++++++++++++++++----------------------
> >  3 files changed, 28 insertions(+), 25 deletions(-)
> >
>