From: Klaus Jensen <its@irrelevant.dk>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH 1/2] block/nvme: Properly display doorbell stride length in trace event
Date: Wed, 27 Jan 2021 22:30:01 +0100 [thread overview]
Message-ID: <YBHbWX0EuIXOsqyN@apples.localdomain> (raw)
In-Reply-To: <20210127212137.3482291-2-philmd@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1346 bytes --]
On Jan 27 22:21, Philippe Mathieu-Daudé wrote:
> Commit 15b2260bef3 ("block/nvme: Trace controller capabilities")
> misunderstood the doorbell stride value from the datasheet, use
> the correct one. The 'doorbell_scale' variable used few lines
> later is correct.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
> ---
> block/nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/nvme.c b/block/nvme.c
> index 5a6fbacf4a5..80c4318d8fc 100644
> --- a/block/nvme.c
> +++ b/block/nvme.c
> @@ -745,7 +745,7 @@ static int nvme_init(BlockDriverState *bs, const char *device, int namespace,
> trace_nvme_controller_capability("Contiguous Queues Required",
> NVME_CAP_CQR(cap));
> trace_nvme_controller_capability("Doorbell Stride",
> - 2 << (2 + NVME_CAP_DSTRD(cap)));
> + 1 << (2 + NVME_CAP_DSTRD(cap)));
> trace_nvme_controller_capability("Subsystem Reset Supported",
> NVME_CAP_NSSRS(cap));
> trace_nvme_controller_capability("Memory Page Size Minimum",
> --
> 2.26.2
>
>
--
One of us - No more doubt, silence or taboo about mental illness.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-01-27 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 21:21 [PATCH 0/2] block/nvme: Minor tracing improvements Philippe Mathieu-Daudé
2021-01-27 21:21 ` [PATCH 1/2] block/nvme: Properly display doorbell stride length in trace event Philippe Mathieu-Daudé
2021-01-27 21:30 ` Klaus Jensen [this message]
2021-01-27 21:21 ` [PATCH 2/2] block/nvme: Trace NVMe spec version supported by the controller Philippe Mathieu-Daudé
2021-01-27 21:32 ` Klaus Jensen
2021-02-02 14:44 ` [PATCH 0/2] block/nvme: Minor tracing improvements Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBHbWX0EuIXOsqyN@apples.localdomain \
--to=its@irrelevant.dk \
--cc=fam@euphon.net \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.