From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Ian Jackson <iwj@xenproject.org>
Cc: Manuel Bouyer <bouyer@netbsd.org>,
<xen-devel@lists.xenproject.org>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>,
Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3] NetBSD: use system-provided headers
Date: Wed, 3 Feb 2021 19:27:30 +0100 [thread overview]
Message-ID: <YBrrEulPi+27bV2u@Air-de-Roger> (raw)
In-Reply-To: <24602.56532.169889.71270@mariner.uk.xensource.com>
On Wed, Feb 03, 2021 at 05:26:44PM +0000, Ian Jackson wrote:
> Manuel Bouyer writes ("[PATCH v3] NetBSD: use system-provided headers"):
> > +#ifdef __NetBSD__
> > +#include <xen/xenio.h>
> > +#else
> > #include <xen/sys/privcmd.h>
> > +#endif
> > #include <xen/foreign/x86_32.h>
> > #include <xen/foreign/x86_64.h>
> Maneul, thanks. I think this is a bugfix and ought in principle to go
> in but I think we probably want to do this with configure rather than
> ad-hoc ifdefs.
>
> Roger, what do you think ? Were you going to add a configure test for
> the #ifdef that we put in earlier ?
Yes, sorry, I owe you that patch. Will try to do tomorrow so that we
can have a model for other headers. AFAICT I will have to build
something around AC_CHECK_HEADER so that we can get a define that
contains a path that can be used with an #include directive.
Thanks, Roger.
next prev parent reply other threads:[~2021-02-03 18:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 16:54 [PATCH] add a qemu-ifup script on NetBSD Manuel Bouyer
2021-02-03 16:54 ` [PATCH] xenstored: close socket connections on error Manuel Bouyer
2021-02-03 17:24 ` Ian Jackson
2021-02-03 17:38 ` Ian Jackson
2021-02-03 17:48 ` Manuel Bouyer
2021-02-04 11:11 ` Jürgen Groß
2021-02-04 11:16 ` Manuel Bouyer
2021-02-04 11:18 ` Jürgen Groß
2021-02-04 11:42 ` Ian Jackson
2021-02-03 16:54 ` [PATCH v3] Document qemu-ifup on NetBSD Manuel Bouyer
2021-02-03 16:54 ` [PATCH v3] NetBSD: use system-provided headers Manuel Bouyer
2021-02-03 17:26 ` Ian Jackson
2021-02-03 18:27 ` Roger Pau Monné [this message]
2021-02-03 17:19 ` [PATCH] add a qemu-ifup script on NetBSD Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBrrEulPi+27bV2u@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=bouyer@netbsd.org \
--cc=elena.ufimtseva@oracle.com \
--cc=iwj@xenproject.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.