Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO

From: Leon Romanovsky <leon@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Julian Braha <julianbraha@gmail.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
	Zhu Yanjun <zyjzyj2000@gmail.com>,
	Doug Ledford <dledford@redhat.com>,
	RDMA mailing list <linux-rdma@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: infiniband: sw: rxe: fix kconfig dependency on CRYPTO
Date: Wed, 24 Feb 2021 12:04:19 +0200	[thread overview]
Message-ID: <YDYko5zdCkssqw3t@unreal> (raw)
In-Reply-To: <CAK8P3a1XW0NTFHiEUoLgeHGpKUfYgM8T8Or7ix3m6Fd-TLEn5w@mail.gmail.com>

On Tue, Feb 23, 2021 at 11:05:45PM +0100, Arnd Bergmann wrote:
> On Tue, Feb 23, 2021 at 10:54 PM Julian Braha <julianbraha@gmail.com> wrote:
> > On Tuesday, February 23, 2021 4:26:44 PM EST Arnd Bergmann wrote:
> > > On Tue, Feb 23, 2021 at 9:46 PM Julian Braha <julianbraha@gmail.com> wrote:
> > > >
> > > > I have other similar patches that I intend to submit. What should I do,
> > > > going forward? Should I use "depends on CRYPTO" for cases like these?
> > > > Should I resubmit this patch with that change?
> > >
> > > No, we should not mix the two methods, that just leads to circular dependencies.
> > >
> > > How many more patches do you have that need to get merged?
> > >
> > > If it's only a few, I'd suggest merging them first before we consider a
> > > broader change. If the problem is very common, we may want to
> > > think about alternative approaches first, and then change everything
> > > at once.
> >
> > Sorry, I don't have a specific number, but it's certainly under a dozen patches.
>
> It's probably best to continue pushing those first then.

Arnd,

I'm hearing it over and over for a long time already. People are focused
on micro-solutions instead of one, powerful change, which is not hard to
do.

Thanks

>
>         Arnd