From: Michal Hocko <mhocko@suse.com>
To: Yang Shi <shy828301@gmail.com>
Cc: hannes@cmpxchg.org, guro@fb.com, shakeelb@google.com,
akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] doc: memcontrol: add description for oom_kill
Date: Fri, 26 Feb 2021 08:30:22 +0100 [thread overview]
Message-ID: <YDijjovHAer2tiL5@dhcp22.suse.cz> (raw)
In-Reply-To: <20210226021254.3980-1-shy828301@gmail.com>
On Thu 25-02-21 18:12:54, Yang Shi wrote:
> When debugging an oom issue, I found the oom_kill counter of memcg is
> confusing. At the first glance without checking document, I thought it
> just counts for memcg oom, but it turns out it counts both global and
> memcg oom.
Yes, this is the case indeed. The point of the counter was to count oom
victims from the memcg rather than matching that to the source of the
oom. Rememeber that this could have been a memcg oom up in the
hierarchy as well. Counting victims on the oom origin could be equally
confusing because in many cases there would be no victim counted for the
above mentioned memcg ooms.
> The cgroup v2 documents it, but the description is missed for cgroup v1.
>
> Signed-off-by: Yang Shi <shy828301@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> Documentation/admin-guide/cgroup-v1/memory.rst | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentation/admin-guide/cgroup-v1/memory.rst
> index 0936412e044e..44d5429636e2 100644
> --- a/Documentation/admin-guide/cgroup-v1/memory.rst
> +++ b/Documentation/admin-guide/cgroup-v1/memory.rst
> @@ -851,6 +851,9 @@ At reading, current status of OOM is shown.
> (if 1, oom-killer is disabled)
> - under_oom 0 or 1
> (if 1, the memory cgroup is under OOM, tasks may be stopped.)
> + - oom_kill integer counter
> + The number of processes belonging to this cgroup killed by any
> + kind of OOM killer.
>
> 11. Memory Pressure
> ===================
> --
> 2.26.2
>
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-02-26 7:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 2:12 [PATCH] doc: memcontrol: add description for oom_kill Yang Shi
2021-02-26 7:30 ` Michal Hocko [this message]
2021-02-26 16:42 ` Yang Shi
2021-02-26 16:42 ` Yang Shi
2021-02-26 19:19 ` Yang Shi
2021-02-26 19:19 ` Yang Shi
2021-03-01 12:24 ` Michal Hocko
2021-03-01 17:17 ` Yang Shi
2021-03-01 17:17 ` Yang Shi
2021-03-01 12:15 ` Michal Hocko
2021-03-01 17:07 ` Yang Shi
2021-03-01 17:07 ` Yang Shi
2021-02-26 14:23 ` Shakeel Butt
2021-02-26 14:23 ` Shakeel Butt
2021-02-26 14:33 ` Chris Down
2021-03-01 21:20 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDijjovHAer2tiL5@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shakeelb@google.com \
--cc=shy828301@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.