From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
Corey Minyard <cminyard@mvista.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>
Subject: Re: regression with TTY changes in v5.12-rc1
Date: Thu, 4 Mar 2021 17:20:28 +0100 [thread overview]
Message-ID: <YEEIzO7BrsAwM1LG@kroah.com> (raw)
In-Reply-To: <00154592-c5ee-aaba-956e-b265473b53bc@linux.intel.com>
On Thu, Mar 04, 2021 at 08:37:44AM -0600, Pierre-Louis Bossart wrote:
> Hi,
> Our SOF/audio CI shows an across-the-board regression when we try v5.12-rc1,
> specifically on pause/resume tests with an interactive terminal running
> 'aplay -i' commands managed by expect to simulate the user pressing the
> space bar to pause/unpause. It turns out the processes are not longer killed
> and the audio devices remain busy (see publicly available test results
> listed below).
>
> git bisect points to commit 33d4ae9885987 ("drivers:tty:pty: Fix a race
> causing data loss on close"). Reverting the patch fixes the issue on all
> test devices.
>
> Further analysis with Corey Minyard points to a problem where a slave tty
> will not get a SIGHUP when the master is closed.
>
> Unless there is an alternate fix, a revert looks necessary?
>
> Regards
> -Pierre
>
> https://github.com/thesofproject/linux/pull/2772
> https://sof-ci.01.org/linuxpr/PR2772/build5352/devicetest/
Now reverted.
thanks,
greg k-h
prev parent reply other threads:[~2021-03-04 16:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 14:37 regression with TTY changes in v5.12-rc1 Pierre-Louis Bossart
2021-03-04 16:20 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEEIzO7BrsAwM1LG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=broonie@kernel.org \
--cc=cminyard@mvista.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.