From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Caleb Connolly <caleb@connolly.tech>
Cc: andi@etezian.org, Rob Herring <robh@kernel.org>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] input: s6sy761: fix coordinate read bit shift
Date: Sun, 7 Mar 2021 15:13:27 -0800 [thread overview]
Message-ID: <YEVeFz0wFtLXRG7v@google.com> (raw)
In-Reply-To: <20210305185710.225168-1-caleb@connolly.tech>
On Fri, Mar 05, 2021 at 06:58:10PM +0000, Caleb Connolly wrote:
> The touch coordinate register contains the following:
>
> byte 3 byte 2 byte 1
> +--------+--------+ +-----------------+ +-----------------+
> | | | | | | |
> | X[3:0] | Y[3:0] | | Y[11:4] | | X[11:4] |
> | | | | | | |
> +--------+--------+ +-----------------+ +-----------------+
>
> Bytes 2 and 1 need to be shifted left by 4 bits, the least significant
> nibble of each is stored in byte 3. Currently they are only
> being shifted by 3 causing the reported coordinates to be incorrect.
>
> This matches downstream examples, and has been confirmed on my
> device (OnePlus 7 Pro).
>
> Fixes: 0145a7141e59 ("Input: add support for the Samsung S6SY761
> touchscreen")
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-03-07 23:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 18:58 [PATCH v2] input: s6sy761: fix coordinate read bit shift Caleb Connolly
2021-03-06 10:33 ` Andi Shyti
2021-03-07 23:13 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEVeFz0wFtLXRG7v@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andi@etezian.org \
--cc=caleb@connolly.tech \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.