From: Sean Christopherson <seanjc@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Nathan Tempelman <natet@google.com>,
Thomas Lendacky <thomas.lendacky@amd.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Steve Rutherford <srutherford@google.com>,
David Rientjes <rientjes@google.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Ashish Kalra <Ashish.Kalra@amd.com>
Subject: Re: [RFC] KVM: x86: Support KVM VMs sharing SEV context
Date: Tue, 16 Mar 2021 11:08:34 -0700 [thread overview]
Message-ID: <YFD0IuaMACWZyGtG@google.com> (raw)
In-Reply-To: <df2e2cd9-18d5-f35e-6c05-5ba0c399ccbe@redhat.com>
On Tue, Mar 16, 2021, Paolo Bonzini wrote:
> On 16/03/21 18:52, Sean Christopherson wrote:
> > > I don't
> > > know that holding the fd instead of the kvm makes that much better though,
> > > are there advantages to that I'm not seeing?
> > If there's no kvm pointer, it's much more difficult for someone to do the wrong
> > thing, and any such shenanigans stick out like a sore thumb in patches, which
> > makes reviewing future changes easier.
>
> On the other hand holding the fd open complicates the code, reference
> counting rules are already hard enough.
How so? KVM already has to do "fget(source_kvm)", can't we just hold onto to
that instead of doing an additional kvm_get_kvm()?
next prev parent reply other threads:[~2021-03-16 18:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 8:59 [RFC] KVM: x86: Support KVM VMs sharing SEV context Nathan Tempelman
2021-02-24 9:18 ` Paolo Bonzini
2021-02-24 16:58 ` Sean Christopherson
2021-02-25 11:26 ` Paolo Bonzini
2021-02-24 17:37 ` Sean Christopherson
2021-02-25 3:55 ` Steve Rutherford
2021-03-12 23:47 ` Nathan Tempelman
2021-03-16 17:52 ` Sean Christopherson
2021-03-16 17:58 ` Paolo Bonzini
2021-03-16 18:08 ` Sean Christopherson [this message]
2021-02-25 3:44 ` Steve Rutherford
2021-02-25 14:57 ` Tom Lendacky
2021-02-25 18:49 ` Steve Rutherford
2021-03-05 22:36 ` Ashish Kalra
2021-03-09 17:45 ` Sean Christopherson
2021-02-25 17:53 ` James Bottomley
2021-02-25 18:18 ` Ashish Kalra
2021-02-25 20:33 ` Paolo Bonzini
2021-02-26 13:30 ` Ashish Kalra
2021-02-25 20:36 ` Paolo Bonzini
2021-03-05 14:04 ` Ashish Kalra
2021-03-05 15:13 ` Paolo Bonzini
2021-03-05 20:43 ` Nathan Tempelman
2021-03-11 15:30 ` Tobin Feldman-Fitzthum
2021-03-11 16:29 ` Paolo Bonzini
2021-03-15 17:05 ` Tobin Feldman-Fitzthum
2021-03-15 17:29 ` Paolo Bonzini
2021-05-24 21:29 ` Kalra, Ashish
2021-05-24 21:29 ` Kalra, Ashish
2021-05-27 15:51 ` Kalra, Ashish
2021-05-27 15:51 ` Kalra, Ashish
2021-06-01 8:26 ` Kalra, Ashish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFD0IuaMACWZyGtG@google.com \
--to=seanjc@google.com \
--cc=Ashish.Kalra@amd.com \
--cc=brijesh.singh@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natet@google.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=srutherford@google.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.