Re: [PATCH v11 5/6] xfs/529: quotas and idmapped mounts

From: Eryu Guan <guan@eryu.me>
To: Christian Brauner <brauner@kernel.org>
Cc: fstests@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
	"Darrick J . Wong" <djwong@kernel.org>,
	David Howells <dhowells@redhat.com>,
	Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH v11 5/6] xfs/529: quotas and idmapped mounts
Date: Mon, 29 Mar 2021 02:38:36 +0800	[thread overview]
Message-ID: <YGDNLJaZ/1X3O4lb@desktop> (raw)
In-Reply-To: <20210327111856.1211544-6-brauner@kernel.org>

On Sat, Mar 27, 2021 at 12:18:55PM +0100, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
> 
> Test that xfs quota behave correctly on idmapped mounts.
> Mount a scratch device with user and group quota support enabled. Create
> directories "unmapped" and "idmapped". Create files in the unampped
> mount and verify quota behavior. Create files through the idmapped mount
> and verify identical behavior.
> 
> Cc: Eryu Guan <guan@eryu.me>
> Cc: Darrick J. Wong <djwong@kernel.org>
> Cc: fstests@vger.kernel.org
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
> ---
> /* v1 - v8 */
> patch not present
> 
> /* v9 */
> - Christian Brauner <christian.brauner@ubuntu.com>:
>   - Rebased on current master.
> 
> /* v10 */
> - Eryu Guan <guan@eryu.me>:
>   - Remove leading "_" from local helpers.
>   - Remove redundant "-q" option from umount -l calls.
>   - Use wipe_mount() in a few more places.
> 
> /* v11 */
> - Amir Goldstein <amir73il@gmail.com>:
>   - Add a dedicated "idmapped" tag for idmapped mounts tests.
> ---
>  tests/xfs/529     | 378 ++++++++++++++++++++++++++
>  tests/xfs/529.out | 657 ++++++++++++++++++++++++++++++++++++++++++++++
>  tests/xfs/group   |   1 +
>  3 files changed, 1036 insertions(+)
>  create mode 100644 tests/xfs/529
>  create mode 100644 tests/xfs/529.out
> 
> diff --git a/tests/xfs/529 b/tests/xfs/529
> new file mode 100644
> index 00000000..a5607306
> --- /dev/null
> +++ b/tests/xfs/529
> @@ -0,0 +1,378 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0+
> +#
> +# Copyright (c) 2021 Christian Brauner <christian.brauner@ubuntu.com>
> +# All Rights Reserved.
> +#
> +# FS QA Test No. 529
> +#
> +# Exercise basic xfs_quota functionality (user/group/project quota)
> +# Use of "sync" mount option here is an attempt to get deterministic
> +# allocator behaviour.
> +#
> +seq=`basename $0`
> +seqres=$RESULT_DIR/$seq
> +echo "QA output created by $seq"
> +
> +here=`pwd`
> +tmp=/tmp/$$
> +status=1	# failure is the default!
> +trap "_cleanup; exit \$status" 0 1 2 3 15
> +
> +wipe_mounts()
> +{
> +	umount -l "${SCRATCH_MNT}/idmapped" >/dev/null 2>&1

If lazy umount is not necessary, please just use bare umount, I found it
hard to debug if someone is holding the mount.

$UMOUNT_PROG "${SCRATCH_MNT}/idmapped"

Thanks,
Eryu