From: Vinod Koul <vkoul@kernel.org>
To: Bard Liao <yung-chuan.liao@linux.intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org,
pierre-louis.bossart@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH 0/2] soundwire: configure block packing mode with new
Date: Tue, 30 Mar 2021 14:36:42 +0530 [thread overview]
Message-ID: <YGLqIjJnT0VAUoWa@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20210323050701.23760-1-yung-chuan.liao@linux.intel.com>
On 23-03-21, 13:06, Bard Liao wrote:
> The existing code multiply a channel number by zero (SDW_BLK_GRP_CNT_1),
> and the result is used to configure the block packing mode. Sampling
> grouping and channel packing are two separate concepts in SoundWire.
>
> In addition, the bandwidth allocation allocates a vertical slice for
> each stream, which makes the use of the PER_CHANNEL packing mode
> irrelevant.
>
> Let's use the proper definition for block packing mode (PER_PORT).
>
> This change has no functional impact though since the net result is
> the same configuration of the DPN_BlockCtrl3 register, when implemented.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2021-03-30 9:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 5:06 [PATCH 0/2] soundwire: configure block packing mode with new Bard Liao
2021-03-23 5:07 ` [PATCH 1/2] soundwire: add definition for DPn BlockPackingMode Bard Liao
2021-03-23 5:07 ` [PATCH 2/2] soundwire: generic_allocation: fix confusion between group and packing Bard Liao
2021-03-30 9:06 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YGLqIjJnT0VAUoWa@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.