Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system

From: Greg KH <gregkh@linuxfoundation.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	lukasz.luba@arm.com, rafael@kernel.org,
	Ram Chandrasekar <rkumbako@codeaurora.org>
Subject: Re: [PATCH v6 2/7] powercap/drivers/dtpm: Create a registering system
Date: Fri, 2 Apr 2021 13:48:39 +0200	[thread overview]
Message-ID: <YGcEl8gsSIcmyLf1@kroah.com> (raw)
In-Reply-To: <c819700a-97b6-9993-491b-599b82842dc2@linaro.org>

On Fri, Apr 02, 2021 at 01:10:51PM +0200, Daniel Lezcano wrote:
> >> To answer your questions, there is a SoC vendor thermal daemon using
> >> DTPM and there is a tool created to watch the thermal framework and read
> >> the DTPM values, it is available at [4]. It is currently under
> >> development with the goal of doing power rebalancing / capping across
> >> the different nodes when there is a violation of the parent's power limit.
> > 
> > Crazy ideas aside, your implementation of this is my main objection
> > here.  You are creating a user/kernel api that you will have to support
> > for 20+ years, without a real userspace user just yet (from what I can
> > tell).  That's rough, and is going to mean that this gets messy over
> > time.
> 
> I'm not sure to understand, the API already exists since v3.3, it is the
> powercap and DTPM is its backend. AFAICT, there are already users of it
> except they create their own way to build the hierarchy today.

The configfs api is what I am referring to here, the ones in this patch
series...

thanks,

greg k-h