From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>,
linux-pwm@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/3] pwm: lpss: Don't modify HW state in .remove callback
Date: Fri, 9 Apr 2021 15:21:40 +0200 [thread overview]
Message-ID: <YHBU5MqK+vjTGwio@orome.fritz.box> (raw)
In-Reply-To: <20210407080155.55004-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Wed, Apr 07, 2021 at 10:01:53AM +0200, Uwe Kleine-König wrote:
> A consumer is expected to disable a PWM before calling pwm_put(). And if
> they didn't there is hopefully a good reason (or the consumer needs
> fixing). Also if disabling an enabled PWM was the right thing to do,
> this should better be done in the framework instead of in each low level
> driver.
>
> So drop the hardware modification from the .remove() callback.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pwm/pwm-lpss.c | 6 ------
> 1 file changed, 6 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-09 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 8:01 [PATCH 1/3] pwm: lpss: Don't modify HW state in .remove callback Uwe Kleine-König
2021-04-07 8:01 ` [PATCH 2/3] pwm: Add a devm managed function to add pwm_chips Uwe Kleine-König
2021-04-07 8:01 ` [PATCH 3/3] pwm: lpss: Simplify using devm_pwmchip_add Uwe Kleine-König
2021-04-09 13:28 ` Thierry Reding
2021-04-09 21:47 ` Uwe Kleine-König
2021-04-09 13:21 ` Thierry Reding [this message]
2021-04-10 13:46 ` [PATCH 1/3] pwm: lpss: Don't modify HW state in .remove callback Uwe Kleine-König
2021-04-10 21:26 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YHBU5MqK+vjTGwio@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.